forked from anomalyco/opencode
-
Notifications
You must be signed in to change notification settings - Fork 2
Integration #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Integration #31
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
38376f4
PATCH /config hot-reload w/ selective cache invalidation (#15)
shuv1337 f471203
Merge branch 'dev' into config-hot-reload
shuv1337 3dbd5ed
typecheck fix
shuv1337 df3e955
chore: format code
actions-user f71cb8b
Merge branch 'dev' into config-hot-reload
shuv1337 6ee86eb
fix for failing test
shuv1337 725a878
fix for failing test
shuv1337 865955e
chore: format code
actions-user bdf7f7d
Merge branch 'dev' into config-hot-reload
shuv1337 bad3021
Merge branch 'integration' into config-hot-reload
shuv1337 f28361f
chore: format code
actions-user 410fd58
Merge branch 'integration' into config-hot-reload
shuv1337 37527bd
Fix cache corruption from partial updates in file refresh (#18)
Copilot ce411d0
Merge branch 'integration' into config-hot-reload
shuv1337 66546ce
Add favorites to model selector (#23)
shuv1337 e3d696e
Merge branch 'integration' into config-hot-reload
shuv1337 03d3c80
revert desktop changes
shuv1337 76d48d8
revert desktop changes
shuv1337 4d5f6b5
proper fix for image attachments
shuv1337 26b6b1e
Merge branch 'dev' into fix-tui-img-attachments
shuv1337 f3b5b37
chore: format code
actions-user 2c264a7
Merge branch 'dev' into add-model-favorites
shuv1337 a069899
Update Nix flake.lock and hashes
actions-user d9a0881
chore: format code
actions-user 1aedc8a
chore: format code
actions-user 0a1f6d8
fix syntax error
shuv1337 15b72aa
Merge branch 'dev' into add-model-favorites
shuv1337 51eaba8
Merge branch 'dev' into fix-tui-img-attachments
shuv1337 16aed1b
chore: format code
actions-user e6b665e
Merge branch 'dev' into add-model-favorites
shuv1337 0b96087
Merge branch 'dev' into fix-tui-img-attachments
shuv1337 a8832fa
Update Nix flake.lock and hashes
actions-user fd4d38b
Merge branch 'dev' into add-model-favorites
shuv1337 65b7569
Merge branch 'dev' into fix-tui-img-attachments
shuv1337 1296e46
Merge origin/dev into config-hot-reload
shuv1337 9c9d2ed
Merge branch 'dev' into fix-tui-img-attachments
rekram1-node 8cfe611
fix: resolve type error in provider configuration loop
shuv1337 980c331
gen sdk
shuv1337 62a8131
Update Nix flake.lock and hashes
actions-user 01133dd
Merge branch 'dev' into config-hot-reload
shuv1337 3f44edd
Merge branch 'sst:dev' into integration
shuv1337 a4cbc52
Update Nix flake.lock and hashes
actions-user f1ff202
Local test merge of PR #29: Config hot reload
shuv1337 cf53bc3
Local test merge of PR #27: Add model favorites
shuv1337 3538e54
Local test merge of PR #26: proper fix for image attachments
shuv1337 4423bc5
Local test merge of PR #30: Merge Dev into Integration
shuv1337 6d6be71
Local test merge of dev into integration: whitelist/blacklist provide…
shuv1337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permission merging can drop safe defaults and mutates config objects
Two subtle issues in the permission path:
Loss of
doom_loop/external_directorydefaultsagentPermissionandplanPermissioncorrectly start fromdefaultPermission/planPermission(withdoom_loop/external_directorydefaulting to"ask"), merged withcfg.permission.for (const [key, value] of Object.entries(cfg.agent ?? {}))loop, the finalif (permission ?? cfg.permission)branch overwritesitem.permissionwithmergeAgentPermissions(cfg.permission ?? {}, permission ?? {}), which ignoresdefaultPermission.cfg.agent(including overrides of built-ins) and a globalcfg.permissionthat doesn’t mentiondoom_loop/external_directory, the merged result can change those fields from"ask"toundefined. This weakens the default safety posture for those overrides.Consider basing this merge on the agent’s existing permission (
item.permission) instead, e.g.mergeAgentPermissions(item.permission, permission ?? {}), so that per-agent overrides extend the default rather than replacing it.mergeAgentPermissionsmutates its argumentsbasePermission.bashandoverridePermission.bashwhen they’re strings. Ifcfg.permissionis passed in, this mutates the shared config object and may have surprising side effects elsewhere that readcfg.permission.Addressing both would make the permission model safer and easier to reason about.
Also applies to: 226-263