You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't have a reproducible dev env right now. Some of our make commands implicitly depend on some binaries being installed on the host environment. make go-gen-mocks is one example dependency that caused some issues in a PR, where the repo was using https://github.com/golang/mock as a dependency but I had mockgen go installed from https://github.com/uber-go/mock. Hence running make go-gen-mocks created types that were incompatible with the tests. This is one example, we probably have more.
Issue
We don't have a reproducible dev env right now. Some of our make commands implicitly depend on some binaries being installed on the host environment.
make go-gen-mocks
is one example dependency that caused some issues in a PR, where the repo was using https://github.com/golang/mock as a dependency but I had mockgengo install
ed from https://github.com/uber-go/mock. Hence runningmake go-gen-mocks
created types that were incompatible with the tests. This is one example, we probably have more.See #226 (comment) for context.
Solution
We can use nix, or mise, or whatever. Have a preference against devcontainers because I don't like working with them personally.
WIP list of dependencies that we need to track:
make go-gen-mocks
is not reproducible right now, see issue section at the top)The text was updated successfully, but these errors were encountered: