Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reproducible dev env #236

Open
samlaf opened this issue Jan 10, 2025 · 0 comments
Open

Create reproducible dev env #236

samlaf opened this issue Jan 10, 2025 · 0 comments

Comments

@samlaf
Copy link
Collaborator

samlaf commented Jan 10, 2025

Issue

We don't have a reproducible dev env right now. Some of our make commands implicitly depend on some binaries being installed on the host environment. make go-gen-mocks is one example dependency that caused some issues in a PR, where the repo was using https://github.com/golang/mock as a dependency but I had mockgen go installed from https://github.com/uber-go/mock. Hence running make go-gen-mocks created types that were incompatible with the tests. This is one example, we probably have more.

See #226 (comment) for context.

Solution

We can use nix, or mise, or whatever. Have a preference against devcontainers because I don't like working with them personally.

WIP list of dependencies that we need to track:

  • mockgen (make go-gen-mocks is not reproducible right now, see issue section at the top)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant