-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host returns error when invalid cert is sent to proxy #25
Comments
This is during GET requests right? What is currently returned upon error? 400? 500? What's your suggestion for modifying proxy to have the information you need? |
Two solutions:
Currently as far as I understand, the error flow like below
I have gone deep when it got to 3, but from the comment it will continue to retry that cert, and essentially deadlock the system |
Definitely prefer returning an explicit error with http error code. |
As far as I can tell, this is a problem which proxy needs to address in order to prevent a malicious OP batcher. This issue should open under proxy repo |
related issue, Layr-Labs/eigenda-proxy#243 (comment) |
When there is an invalid cert i.e. the signature is wrong (parsing error itself is already handled within the client inside the derivation pipeline), proxy should inform the host about it.
The host should handle such error and only return empty bytes for all field element. The line to fix is here (https://github.com/Layr-Labs/hokulea/blob/master/bin/host/src/eigenda_fetcher/mod.rs#L150).
As such, the oracle client can detect it here https://github.com/Layr-Labs/hokulea/blob/master/crates/proof/src/eigenda_provider.rs#L90
The text was updated successfully, but these errors were encountered: