Skip to content

1082 - Linting Performance #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumodon wants to merge 31 commits into
base: master
Choose a base branch
from
Open

1082 - Linting Performance #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
2676cd6
Implements all linting fixes from merge
lumodon Sep 11, 2017
4bbf239
Removes errors from overzelous import changing
lumodon Sep 18, 2017
424472c
Resets test stub files in attempt to get to test-passing state
lumodon Sep 18, 2017
c96b5ed
Removes 'default' changes but keeps other linting fixes
lumodon Sep 18, 2017
6c7c8b6
imports were expecting an object, changes this to export single objec…
lumodon Sep 18, 2017
9a7cc46
Changes export to be object instead of named exports
lumodon Sep 18, 2017
dc44643
Fixes default export for stubs
lumodon Sep 18, 2017
5ab6ef2
Fixes export of usedFixture to use default
lumodon Sep 18, 2017
6746a48
Fixes default export for helpers database
lumodon Sep 18, 2017
4d7bbc0
Ignores import/named linting rule for dataService
lumodon Sep 18, 2017
82fa22c
Fixes default export for workers
lumodon Sep 18, 2017
97635be
Takes care of maximum callback linting errors
lumodon Sep 19, 2017
519af76
Changes default export for chapterCreated
lumodon Sep 19, 2017
de194fb
Export default for jwt utility
lumodon Sep 19, 2017
66f23e1
surveyService testing helper export default
lumodon Sep 19, 2017
b450f8c
Default export for quickTeamFormation test helper
lumodon Sep 19, 2017
a9cd2ba
Export default for team formation error
lumodon Sep 19, 2017
8e7d4e1
Export default for getGoalInfo
lumodon Sep 19, 2017
69db8f6
Removed accidental inclusion of "index" as module
lumodon Sep 19, 2017
75acee3
Fixes export for crmService test
lumodon Sep 19, 2017
506ecf0
Fixes server default export
lumodon Sep 19, 2017
0a14e05
Fixes import of Project
lumodon Sep 19, 2017
fa4b45e
Fixes import of processStateChangefeed
lumodon Sep 19, 2017
26b622e
Fixes ActionTypes exports/imports
lumodon Sep 19, 2017
fa82f41
Fixes loose import/named
lumodon Sep 19, 2017
9c0fdc6
Partially fixes linting errors for deactiveUsers
lumodon Sep 19, 2017
a06917b
Fixes multiple export/default
lumodon Sep 19, 2017
a0e8cb9
Fixed default exports
lumodon Sep 19, 2017
2f36ea9
Fixes default export for "finish" utility in scripts
lumodon Sep 19, 2017
f967a62
Fixes crmService export that got broken from some previous commit
lumodon Sep 19, 2017
9b21633
Changed absolute path requires to relative path requires
lumodon Sep 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app.env.encrypted
View file
Open in desktop

This file was deleted.

85 changes: 85 additions & 0 deletions metautil/autoloadscript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
const fs = require('fs')

function readdirPromise(dirpath) {
return new Promise((resolve, reject) => {
fs.readdir(dirpath, (err, result) => {
if (err) {
reject(err)
} else {
resolve(result)
}
})
})
}

function writefilePromise(dirpath, content) {
return new Promise((resolve, reject) => {
fs.writeFile(`${dirpath}/index.js`, content, err => {
if (err) {
reject(err)
} else {
resolve(true)
}
})
})
}

function parseFileNames(dirpath) {
return readdirPromise(dirpath)
.then(results => {
if (results) {
const filteredResults = results.filter(e => !e.startsWith('_'))
return filteredResults
}
})
}

function createFileString(arrayOfFiles) {
const parsedInformation = arrayOfFiles.reduce((accumulator, fileName) => {
const filenameWithoutExtension = fileName.match(/(.*)(?:\.)/)[1]
if (fileName === 'index.js') {
return accumulator
}
return [
accumulator[0].concat(
`import ${filenameWithoutExtension} from '${process.argv[2]}${filenameWithoutExtension}'\n`
), [...accumulator[1], filenameWithoutExtension]
]
}, ['', []])

let string = parsedInformation[0]

string = string
.concat('\nexport default {')
.concat(parsedInformation[1].reduce((str, nameWithoutExtension) => {
return str.concat(`\n ${nameWithoutExtension},`)
}, ''))
.concat('\n}\n')

return Promise.resolve(string)
}

if (!process.argv[2] ||
process.argv[2].length <= 0 ||
!process.argv[3] ||
process.argv[3].length <= 0) {
console.log(`Error - follow this format:
node autoloadscript.js {path} {'log' || 'write'}`)
}

parseFileNames(process.argv[2])
.then(arrayOfFiles => {
return createFileString(arrayOfFiles)
})
.then(fileString => {
if (process.argv[3] === 'log') {
console.log(fileString)
} else if (process.argv[3] === 'write') {
return writefilePromise(process.argv[2], fileString)
}
})
.then(written => {
// This ternary is to make falsy value of "undefined" spit
// out as literally "false" when it doesn't write a file
console.log('written --> ', written ? true : false) // eslint-disable-line no-unneeded-ternary
})
74 changes: 32 additions & 42 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
"@learnersguild/echo-cli": "^2.1.5",
"@learnersguild/idm-jwt-auth": "^2.0.1",
"animal-id": "0.0.1",
"auto-loader": "^0.2.0",
"autoprefixer": "^6.5.3",
"babel-cli": "^6.18.0",
"babel-core": "^6.20.0",
Expand Down Expand Up @@ -118,7 +117,6 @@
"json-loader": "^0.5.4",
"jsonwebtoken": "^7.0.1",
"juration": "0.0.1",
"keymirror": "^0.1.1",
"later": "^1.2.0",
"md5": "^2.1.0",
"micromustache": "^2.1.26",
Expand Down
6 changes: 4 additions & 2 deletions src/common/actions/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import {
import ActionTypes from './types'

const {
APP_SHOW_LOADING,
APP_HIDE_LOADING,
FETCH_DATA_REQUEST,
FETCH_DATA_FAILURE,
FETCH_DATA_SUCCESS,
AUTHORIZATION_ERROR,
DISMISS_ERROR,
} from './types'
} = ActionTypes

export function fetchDataRequest() {
return {type: FETCH_DATA_REQUEST}
Expand Down
4 changes: 3 additions & 1 deletion src/common/actions/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import {UPDATE_JWT, UNAUTHENTICATED_ERROR} from './types'
import ActionTypes from './types'

const {UPDATE_JWT, UNAUTHENTICATED_ERROR} = ActionTypes

export function updateJWT(lgJWT) {
return {type: UPDATE_JWT, lgJWT}
Expand Down
2 changes: 1 addition & 1 deletion src/common/actions/queries/getProjectSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {FEEDBACK_TYPE_DESCRIPTORS} from 'src/common/models/feedbackType'
import FEEDBACK_TYPE_DESCRIPTORS from 'src/common/models/feedbackType'

export default function getProjectSummary(identifier) {
return {
Expand Down
2 changes: 1 addition & 1 deletion src/common/actions/queries/getUserSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {FEEDBACK_TYPE_DESCRIPTORS} from 'src/common/models/feedbackType'
import FEEDBACK_TYPE_DESCRIPTORS from 'src/common/models/feedbackType'

export default function getUserSummary(identifier) {
return {
Expand Down
2 changes: 1 addition & 1 deletion src/common/actions/queries/lockSurvey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {FEEDBACK_TYPE_DESCRIPTORS} from 'src/common/models/feedbackType'
import FEEDBACK_TYPE_DESCRIPTORS from 'src/common/models/feedbackType'

export default function lockSurvey(memberId, projectId) {
return {
Expand Down
2 changes: 1 addition & 1 deletion src/common/actions/queries/unlockSurvey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {FEEDBACK_TYPE_DESCRIPTORS} from 'src/common/models/feedbackType'
import FEEDBACK_TYPE_DESCRIPTORS from 'src/common/models/feedbackType'

export default function unlockSurvey(memberId, projectId) {
return {
Expand Down
Loading