Skip to content

Bad signature on some edge case #2

@xchapron-ledger

Description

@xchapron-ledger

In https://github.com/LedgerHQ/app-icx/blob/master/src/main.c#L521-L526
if rLength == 31, which can happen, then the signature will be invalid and transaction will be rejected by the blockchain.
A simpler implementation would be using cx_ecdsa_sign_rs_no_throw,a nd best would be changing all the crypto call to use directly helpers from https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_standard_app/crypto_helpers.h

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions