Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit is applied even if login/registration failed #5548

Open
Nutomic opened this issue Mar 26, 2025 · 2 comments
Open

Rate limit is applied even if login/registration failed #5548

Nutomic opened this issue Mar 26, 2025 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@Nutomic
Copy link
Member

Nutomic commented Mar 26, 2025

Login and registration have a very low rate limit of 3 requests per hour. This can easily be hit by mistyping the login password three times in a row, or putting the wrong captcha on registration. Afterwards you only see ratelimit errors. To resolve this the rate limit should only be applied if the action was successful.

Also login is a relatively cheap action and can use a higher limit.

@Nutomic Nutomic added the bug Something isn't working label Mar 26, 2025
@Nutomic Nutomic added this to the 1.0.0 milestone Mar 27, 2025
@dessalines
Copy link
Member

We've had this issue before, and I thought we fixed it. It might just be easier to up that rate limit.

@Nutomic
Copy link
Member Author

Nutomic commented Mar 28, 2025

Its not handled in the code, and would be tricky to add. Hopefully it can be done as part of #5550. Agree about increasing the rate limit especially for 0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants