Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fail-on-block input #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

instantiator
Copy link

Context

(Apologies for the unsolicited PR - but I thought I'd see if I could help.) Issue #31 describes an optional input to allow the user to choose if a successfully completed blocking action should be treated as a success or failure.

This change

  • Adds a fail-on-block input, which defaults to "true" (so supporting default behaviour)
  • Adds a getFailOnBlock() function to model.js, to retrieve the current fail-on-block value as a boolean
  • Modifies index.js to use model.getFailOnBlock() to determine whether to report a block as a failure or information

Fixes #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a config option to alter the fail outcome when blocking an issue
1 participant