From 934f025fa1070f551de00ea261e9756c6b98abb1 Mon Sep 17 00:00:00 2001 From: LeyckerS <104737119+LeyckerS@users.noreply.github.com> Date: Mon, 3 Aug 2026 00:41:52 +0200 Subject: [PATCH] =?UTF-8?q?docs:=20record=20#130=20=E2=80=94=20the=20excep?= =?UTF-8?q?tion=20cleanup=20is=20complete?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 5 --- AUTHORS.md | 2 +- CHANGELOG.md | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/AUTHORS.md b/AUTHORS.md index d5091e5..bf81b61 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -14,7 +14,7 @@ first contribution: | [@kushin25](https://github.com/kushin25) | `docs/CLI.md`, the CLI reference (#37) | | [@pollychen-lab](https://github.com/pollychen-lab) | moved the no-Chrome regression into a pytest suite (#38), then moved the download engine into a shared `moon_download.py` (#41) | | NanoRisk6 — *account no longer on GitHub* | pointed the documented verification commands at `pytest tests/` across six files after the test move (issue #43, commit `f9f8f74`) | -| [@AdvaitVarhade](https://github.com/AdvaitVarhade) | made `--proxies` report missing files and skipped lines instead of failing silently (#48); narrowed `native_dialog`'s exception handling and documented four deliberate swallows (#54); narrowed and documented the eight exception handlers in the first slice of `moon_extract.py` without breaking the deferred playwright import (#82) | +| [@AdvaitVarhade](https://github.com/AdvaitVarhade) | made `--proxies` report missing files and skipped lines instead of failing silently (#48); narrowed `native_dialog`'s exception handling and documented four deliberate swallows (#54); narrowed and documented the eight exception handlers in the first slice of `moon_extract.py` without breaking the deferred playwright import (#82), then closed the issue by doing the last slice too (#130) | | [@Moferanoluwa](https://github.com/Moferanoluwa) | added `--version` and made both report flavours record which build wrote them (#61); corrected the `--proxies` documentation that #48 had made stale (#63); brought `docs/ARCHITECTURE.md` in line with the shared download engine (#68); put CI on a 3.10/3.11/3.12 matrix with a `ruff` baseline (#69); made documentation-only pull requests verify their `moon_cli.py` examples against the real parser (#70); annotated the exception handlers in `moon_engine.py` and narrowed the report-save swallow (#71) | | [@RubenSanosh](https://github.com/RubenSanosh) | froze the elapsed-time clock when a run finishes, so the GUI stops counting after the last file lands (#73) | | [@darlenepolek](https://github.com/darlenepolek) | derived the CI byte-compile list from `git ls-files` so it can no longer drift, and made the lint workflow watch its own file (#77) | diff --git a/CHANGELOG.md b/CHANGELOG.md index de22011..509c045 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -66,6 +66,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 whole version. It now tracks the tag again, at `v3.0`. ### Fixed +- **Every `except Exception:` in the extraction and engine layers now names what it catches or + says why it cannot.** The last slice narrows the datanodes page flow to `PlaywrightError` + and the CDP probe to `(URLError, OSError, JSONDecodeError, KeyError)`, completing the + 30-handler cleanup begun in #54 across four slices and three contributors + (#130, @AdvaitVarhade) - **Nothing said that proxies cover downloads only.** `_PROXY_POOL.next()` is consulted in one place — `download_file` — so the download session is proxied and nothing else is: the datanodes Chrome that answers the Turnstile challenge and the fuckingfast `curl_cffi`