Skip to content

Commit aa9b07a

Browse files
Fixes issues with the build script in detecting dump files to upload and analyze
dorny/paths-filter only works on detecting changes to git files not untracked files Add Blame to test runner and upload of sequence file
1 parent 10adbf7 commit aa9b07a

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

.github/workflows/build.yml

+9-11
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ jobs:
159159

160160
- name: Run experiment tests against ${{ env.TEST_PLATFORM }}
161161
id: test-platform
162-
run: vstest.console.exe ./tooling/**/CommunityToolkit.Tests.${{ env.TEST_PLATFORM }}.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=${{ env.TEST_PLATFORM }}.trx"
162+
run: vstest.console.exe ./tooling/**/CommunityToolkit.Tests.${{ env.TEST_PLATFORM }}.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=${{ env.TEST_PLATFORM }}.trx" /Blame
163163

164164
- name: Create test reports
165165
run: |
@@ -182,26 +182,24 @@ jobs:
182182

183183
# https://github.com/dorny/paths-filter#custom-processing-of-changed-files
184184
- name: Detect If any Dump Files
185-
uses: dorny/[email protected]
186-
id: filter
187-
with:
188-
list-files: shell
189-
filters: |
190-
dump:
191-
- added: '${{ github.workspace }}/CrashDumps/*.dmp'
185+
id: detect-dump
186+
if: always()
187+
working-directory: ${{ github.workspace }}
188+
run: |
189+
echo "DUMP_FILE=$(Get-ChildItem .\CrashDumps\*.dmp -ErrorAction SilentlyContinue)" >> $env:GITHUB_OUTPUT
192190
193191
- name: Artifact - WER crash dumps
194192
uses: actions/upload-artifact@v3
195-
if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
193+
if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
196194
with:
197195
name: CrashDumps-${{ matrix.platform }}
198196
path: '${{ github.workspace }}/CrashDumps'
199197

200198
- name: Analyze Dump
201-
if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
199+
if: ${{ steps.detect-dump.outputs.DUMP_FILE != '' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
202200
run: |
203201
dotnet tool install --global dotnet-dump
204-
dotnet-dump analyze ${{ steps.filter.outputs.dump_files }} -c "clrstack" -c "pe -lines" -c "exit"
202+
dotnet-dump analyze ${{ steps.detect-dump.outputs.DUMP_FILE }} -c "clrstack" -c "pe -lines" -c "exit"
205203
206204
wasm-linux:
207205
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)