Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep our fork synced with RESPEC's repo #10

Open
aufdenkampe opened this issue May 19, 2020 · 3 comments
Open

Keep our fork synced with RESPEC's repo #10

aufdenkampe opened this issue May 19, 2020 · 3 comments
Assignees

Comments

@aufdenkampe
Copy link
Member

We would all benefit from syncing from the master repo, https://github.com/respec/HSPsquared, anytime it changes and before we do a round of work.

We're all ideally following the collaborative feature branch workflows described in respec#30.

Look for new commits from RESPEC at https://github.com/respec/HSPsquared/network.

There are two ways of keeping our repo synced.

  1. Use GitHub web application to create a pull request.
  • This is easy and allows for a nice review step before merging.
  • It always creates a merge commit.
  • The default is to request that RESPEC pull from our repo, whereas we want the opposite direction for a sync, to pull into our repo from RESPEC. So configure the GitHub UI to look like this: image
  1. Use the command line to do a git merge upstream/master

cc: @rheaphy

@aufdenkampe
Copy link
Member Author

@steveskrip, I've just fully updated all of our branches with all commits from RESPEC.
So, our develop branch has now been updated with Bob's new readUCI functions from his master branch.

@aufdenkampe
Copy link
Member Author

@steveskrip, I just pulled in another round of updates from RESPEC based on the recent work by @PaulDudaRESPEC, including the additional readUCI fixes he mentioned in #16 (comment).

Also, I learned and used the helpful $ git cherry-pick <commit ID> function from https://clubmate.fi/git-move-commit-between-branches/. This allowed me to move specific, relevant commits from the develop-WaterQuality branch into our develop. This should allow you to complete the testing for #17.

@aufdenkampe
Copy link
Member Author

I just did a round of syncing with RESPEC's develop, as they've been making progress on Water Quality modules and also the WBN import stuff.

I also deleted our develop-WaterQuality branch after PR #18, because it's been fully merged with develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants