Skip to content

Commit 7ab7ea3

Browse files
committed
fix(about-me): TypeError: 'NoneType' object is not subscriptable for sys_dimensions['cpu_freq'] on some machines
1 parent 78c9186 commit 7ab7ea3

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ Grafana:
2424
Monitoring Plugins:
2525

2626
* about-me: Error in perfdata if using `--dmidecode` and there is no HW information
27+
* about-me: TypeError: 'NoneType' object is not subscriptable for `sys_dimensions['cpu_freq']` on some machines
2728

2829

2930
### Changed ("refactor", "chore" etc.)

check-plugins/about-me/about-me

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ except ImportError:
4040

4141

4242
__author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
43-
__version__ = '2025092201 / v2.2.1'
43+
__version__ = '2025100601 / v2.2.1'
4444

4545
DESCRIPTION = 'Provides a quick overview of host dimensions and software.'
4646

@@ -834,7 +834,8 @@ def main():
834834
sys_dimensions['cpu_logical'],
835835
sys_dimensions['cpu_usable'],
836836
)
837-
msg += 'Current Speed: {} MHz, '.format(int(sys_dimensions['cpu_freq'][0]))
837+
if sys_dimensions['cpu_freq']:
838+
msg += 'Current Speed: {} MHz, '.format(int(sys_dimensions['cpu_freq'][0]))
838839
msg += '{}/{} RAM (virtmem/max'.format(
839840
lib.human.bytes2human(sys_dimensions['ram']),
840841
lib.human.bytes2human(lib.dmidecode.ram(dmi)),
@@ -852,15 +853,17 @@ def main():
852853
sys_dimensions['cpu_logical'],
853854
sys_dimensions['cpu_usable'],
854855
)
855-
msg += 'Current Speed: {} MHz, '.format(int(sys_dimensions['cpu_freq'][0]))
856+
if sys_dimensions['cpu_freq']:
857+
msg += 'Current Speed: {} MHz, '.format(int(sys_dimensions['cpu_freq'][0]))
856858
msg += '{} RAM, '.format(lib.human.bytes2human(lib.dmidecode.ram(dmi)))
857859
elif sys_dimensions:
858860
msg += 'CPUs: {}/{}/{} (phys/lcpu/onln), '.format(
859861
sys_dimensions['cpu_physical'],
860862
sys_dimensions['cpu_logical'],
861863
sys_dimensions['cpu_usable'],
862864
)
863-
msg += 'Current Speed: {} MHz, '.format(int(sys_dimensions['cpu_freq'][0]))
865+
if sys_dimensions['cpu_freq']:
866+
msg += 'Current Speed: {} MHz, '.format(int(sys_dimensions['cpu_freq'][0]))
864867
msg += '{} RAM, '.format(
865868
lib.human.bytes2human(sys_dimensions['ram'])
866869
)
@@ -910,7 +913,8 @@ def main():
910913
perfdata += lib.base.get_perfdata('cpu_logical', sys_dimensions['cpu_logical'], None, None, None, 0, None)
911914
perfdata += lib.base.get_perfdata('cpu_physical', sys_dimensions['cpu_physical'], None, None, None, 0, None)
912915
perfdata += lib.base.get_perfdata('cpu_usable', sys_dimensions['cpu_usable'], None, None, None, 0, None)
913-
perfdata += lib.base.get_perfdata('cpu_freq', int(sys_dimensions['cpu_freq'][0]), None, None, None, 0, lib.dmidecode.cpu_speed(dmi) if args.DMIDECODE and dmi else None)
916+
if sys_dimensions['cpu_freq']:
917+
perfdata += lib.base.get_perfdata('cpu_freq', int(sys_dimensions['cpu_freq'][0]), None, None, None, 0, lib.dmidecode.cpu_speed(dmi) if args.DMIDECODE and dmi else None)
914918
if dmi:
915919
perfdata += lib.base.get_perfdata('ram', lib.dmidecode.ram(dmi), 'B', None, None, 0, None)
916920
elif sys_dimensions:

0 commit comments

Comments
 (0)