Skip to content

Commit ed43930

Browse files
author
Ondrej Rafaj
committed
cleaning code
Signed-off-by: Ondrej Rafaj <[email protected]>
1 parent cd1e953 commit ed43930

7 files changed

+47
-51
lines changed

iJenkins/FTAPIConnector.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ - (NSData *)processDictionaryIntoDataPayload:(NSDictionary *)dictionary {
187187

188188
- (NSURLRequest *)requestForDataObject:(id <FTAPIDataAbstractObject>)data {
189189
NSDictionary *payload = [data payloadData];
190-
NSString *url = [NSString stringWithFormat:@"%@%@%@", [dAccountsManager selectedAccount].baseUrl, [data methodName], [data suffix]];
190+
NSString *url = [NSString stringWithFormat:@"%@%@%@", [[FTAccountsManager sharedManager] selectedAccount].baseUrl, [data methodName], [data suffix]];
191191
if (payload && [data httpMethod] == FTHttpMethodGet) {
192192
BOOL isQM = !([url rangeOfString:@"?"].location == NSNotFound);
193193
NSString *par = [NSString stringWithFormat:@"%@%@", (isQM ? @"&" : @"?"), [NSString serializeParams:payload]];
@@ -198,15 +198,15 @@ - (NSURLRequest *)requestForDataObject:(id <FTAPIDataAbstractObject>)data {
198198
url = [url stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
199199
dFTAPIConnectorDebugFull NSLog(@"Request URL: %@", url);
200200

201-
BOOL authenticate = (dAccountsManager.selectedAccount.username && dAccountsManager.selectedAccount.username.length > 1);
201+
BOOL authenticate = ([FTAccountsManager sharedManager].selectedAccount.username && [FTAccountsManager sharedManager].selectedAccount.username.length > 1);
202202
if (authenticate) {
203203
[[FTAPIConnector sharedClient] clearAuthorizationHeader];
204-
[[FTAPIConnector sharedClient] setAuthorizationHeaderWithUsername:dAccountsManager.selectedAccount.username password:dAccountsManager.selectedAccount.passwordOrToken];
204+
[[FTAPIConnector sharedClient] setAuthorizationHeaderWithUsername:[FTAccountsManager sharedManager].selectedAccount.username password:[FTAccountsManager sharedManager].selectedAccount.passwordOrToken];
205205
}
206206

207207
NSMutableURLRequest *request = [[[FTAPIConnector sharedClient] requestWithMethod:@"" path:@"" parameters:nil] mutableCopy];
208208
[request setURL:[NSURL URLWithString:url]];
209-
NSTimeInterval timeout = dAccountsManager.selectedAccount.timeout;
209+
NSTimeInterval timeout = [FTAccountsManager sharedManager].selectedAccount.timeout;
210210
if (timeout < 1.5) timeout = 8;
211211
[request setTimeoutInterval:timeout];
212212
[request setCachePolicy:NSURLRequestReloadIgnoringLocalAndRemoteCacheData];

iJenkins/FTAccountsManager.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
#import "FTAccount.h"
1010

1111

12-
#define dAccountsManager [FTAccountsManager sharedManager]
13-
14-
1512
@interface FTAccountsManager : NSObject
1613

1714
@property (nonatomic, strong) FTAccount *selectedAccount;

iJenkins/FTAccountsViewController.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ - (FTAccount *)accountForIndexPath:(NSIndexPath *)indexPath {
8484
#pragma mark Creating elements
8585

8686
- (void)createTableView {
87-
_data = [dAccountsManager accounts];
88-
_demoAccounts = [dAccountsManager demoAccounts];
87+
_data = [[FTAccountsManager sharedManager] accounts];
88+
_demoAccounts = [[FTAccountsManager sharedManager] demoAccounts];
8989

9090
[super createTableView];
9191
}
@@ -296,7 +296,7 @@ - (BOOL)tableView:(UITableView *)tableView canEditRowAtIndexPath:(NSIndexPath *)
296296
- (void)tableView:(UITableView *)tableView commitEditingStyle:(UITableViewCellEditingStyle)editingStyle forRowAtIndexPath:(NSIndexPath *)indexPath {
297297
if (editingStyle == UITableViewCellEditingStyleDelete) {
298298
FTAccount *acc = [_data objectAtIndex:indexPath.row];
299-
[dAccountsManager removeAccount:acc];
299+
[[FTAccountsManager sharedManager] removeAccount:acc];
300300
[tableView reloadData];
301301
}
302302
}
@@ -357,7 +357,7 @@ - (UITableViewCell *)accountCellForIndexPath:(NSIndexPath *)indexPath {
357357

358358
// TODO: Finish the API request to check server API, not just reachability
359359
/*
360-
[dAccountsManager setSelectedAccount:acc];
360+
[[FTAccountsManager sharedManager] setSelectedAccount:acc];
361361
FTAPIOverallLoadDataObject *loadObject = [[FTAPIOverallLoadDataObject alloc] init];
362362
[FTAPIConnector connectWithObject:loadObject andOnCompleteBlock:^(id<FTAPIDataAbstractObject> dataObject, NSError *error) {
363363
if (error) {
@@ -431,7 +431,7 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath
431431
if (indexPath.section != 3) {
432432
if ([self datasourceForIndexPath:indexPath].count > 0) {
433433
FTAccount *acc = [self accountForIndexPath:indexPath];
434-
[dAccountsManager setSelectedAccount:acc];
434+
[[FTAccountsManager sharedManager] setSelectedAccount:acc];
435435
[FTAPIConnector resetForAccount:acc];
436436

437437
FTServerHomeViewController *c = [[FTServerHomeViewController alloc] init];
@@ -476,7 +476,7 @@ - (void)tableView:(UITableView *)tableView performAction:(SEL)action forRowAtInd
476476
#pragma mark Add account view controller delegate methods
477477

478478
- (void)addAccountViewController:(FTAddAccountViewController *)controller didAddAccount:(FTAccount *)account {
479-
[dAccountsManager addAccount:account];
479+
[[FTAccountsManager sharedManager] addAccount:account];
480480
[self reloadData];
481481
[self scrollToAccount:account];
482482
[self dismissViewControllerAnimated:YES completion:^{
@@ -485,7 +485,7 @@ - (void)addAccountViewController:(FTAddAccountViewController *)controller didAdd
485485
}
486486

487487
- (void)addAccountViewController:(FTAddAccountViewController *)controller didModifyAccount:(FTAccount *)account {
488-
[dAccountsManager updateAccount:account];
488+
[[FTAccountsManager sharedManager] updateAccount:account];
489489
[self reloadData];
490490
[self scrollToAccount:account];
491491
[self dismissViewControllerAnimated:YES completion:^{

iJenkins/FTLoginAlert.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ - (void)showLoginDialogWithLoginBlock:(FTLoginAlertLoginBlock)loginBlock andCanc
4040

4141
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:FTLangGet(@"Please login") message:nil delegate:self cancelButtonTitle:FTLangGet(@"Cancel") otherButtonTitles:FTLangGet(@"Login"), nil];
4242
[alert setAlertViewStyle:UIAlertViewStyleLoginAndPasswordInput];
43-
[[alert textFieldAtIndex:0] setText:dAccountsManager.selectedAccount.username];
43+
[[alert textFieldAtIndex:0] setText:[FTAccountsManager sharedManager].selectedAccount.username];
4444
[[alert textFieldAtIndex:0] setPlaceholder:FTLangGet(@"Username")];
4545
[alert show];
4646
}
@@ -55,10 +55,10 @@ - (void)showLoginDialogWithLoginBlock:(FTLoginAlertLoginBlock)loginBlock andCanc
5555

5656
- (void)alertView:(UIAlertView *)alertView willDismissWithButtonIndex:(NSInteger)buttonIndex {
5757
if (alertView.alertViewStyle == UIAlertViewStyleLoginAndPasswordInput && (buttonIndex == 1)) {
58-
[dAccountsManager.selectedAccount setUsername:[alertView textFieldAtIndex:0].text];
59-
[dAccountsManager.selectedAccount setPasswordOrToken:[alertView textFieldAtIndex:1].text];
58+
[[FTAccountsManager sharedManager].selectedAccount setUsername:[alertView textFieldAtIndex:0].text];
59+
[[FTAccountsManager sharedManager].selectedAccount setPasswordOrToken:[alertView textFieldAtIndex:1].text];
6060
if (currentLoginBlock) {
61-
currentLoginBlock(dAccountsManager.selectedAccount.username, dAccountsManager.selectedAccount.passwordOrToken);
61+
currentLoginBlock([FTAccountsManager sharedManager].selectedAccount.username, [FTAccountsManager sharedManager].selectedAccount.passwordOrToken);
6262
}
6363
}
6464
else {

iJenkins/FTManageViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
6262
if (!cell) {
6363
cell = [[FTIconCell alloc] initWithStyle:UITableViewCellStyleSubtitle reuseIdentifier:CellIdentifier];
6464
}
65-
BOOL ok = (dAccountsManager.selectedAccount.username && dAccountsManager.selectedAccount.username.length > 0);
65+
BOOL ok = ([FTAccountsManager sharedManager].selectedAccount.username && [FTAccountsManager sharedManager].selectedAccount.username.length > 0);
6666
NSDictionary *d = _data[indexPath.row];
6767
if (![d[@"loginRequired"] boolValue]) {
6868
ok = YES;

iJenkins/FTServerHomeViewController.m

Lines changed: 30 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ @implementation FTServerHomeViewController
4545
- (void)loadData {
4646
if (!_serverObject) {
4747
_isDataAvailable = NO;
48-
self.searchBar.text = @"";
48+
_searchBar.text = @"";
4949

5050
_serverObject = [[FTAPIServerDataObject alloc] init];
5151
if (_selectedView) {
@@ -70,8 +70,8 @@ - (void)loadData {
7070
}
7171
}
7272
else {
73-
if (dAccountsManager.selectedAccount.accountType == FTAccountTypeKeychain) {
74-
[dAccountsManager updateAccount:dAccountsManager.selectedAccount];
73+
if ([FTAccountsManager sharedManager].selectedAccount.accountType == FTAccountTypeKeychain) {
74+
[[FTAccountsManager sharedManager] updateAccount:[FTAccountsManager sharedManager].selectedAccount];
7575
}
7676
[_overviewCell setJobsStats:_serverObject.jobsStats];
7777
if (_serverObject.jobs.count > 0) {
@@ -84,9 +84,9 @@ - (void)loadData {
8484
_views = _serverObject.views;
8585
}
8686

87-
self.jobs = [NSArray arrayWithArray:_serverObject.jobs];
87+
_jobs = [NSArray arrayWithArray:_serverObject.jobs];
8888
[super.tableView reloadData];
89-
[self setTitle:dAccountsManager.selectedAccount.name];
89+
[self setTitle:[FTAccountsManager sharedManager].selectedAccount.name];
9090

9191
if (_serverObject.views.count > 1) {
9292
if (!_selectedView) {
@@ -105,34 +105,19 @@ - (void)loadData {
105105
}
106106
}
107107

108-
#pragma mark Search bar delegate
109-
110-
- (void)filterSearchResultsWithSearchString:(NSString *)searchString
111-
{
112-
NSMutableArray *arr = [NSMutableArray array];
113-
114-
for (FTAPIJobDataObject *job in _serverObject.jobs) {
115-
NSRange isRange = [job.name rangeOfString:searchString options:NSCaseInsensitiveSearch];
116-
if (isRange.location != NSNotFound) {
117-
[arr addObject:job];
118-
}
119-
}
120-
self.searchResults = arr;
121-
}
122-
123108
#pragma mark Creating elements
124109

125110
- (void)createTableView {
126111
[super createTableView];
127112

128-
self.searchBar = [[UISearchBar alloc] initWithFrame:CGRectMake(0, 0, super.tableView.width, 44)];
113+
_searchBar = [[UISearchBar alloc] initWithFrame:CGRectMake(0, 0, self.tableView.width, 44)];
129114

130-
self.searchController = [[UISearchDisplayController alloc] initWithSearchBar:self.searchBar contentsController:self];
131-
self.searchController.searchResultsDataSource = self;
132-
self.searchController.searchResultsDelegate = self;
133-
self.searchController.delegate = self;
115+
_searchController = [[UISearchDisplayController alloc] initWithSearchBar:_searchBar contentsController:self];
116+
[_searchController setSearchResultsDataSource:self];
117+
[_searchController setSearchResultsDelegate:self];
118+
[_searchController setDelegate:self];
134119

135-
[self.tableView setTableHeaderView:self.searchBar];
120+
[self.tableView setTableHeaderView:_searchBar];
136121

137122
_refreshControl = [[UIRefreshControl alloc] init];
138123
[_refreshControl addTarget:self action:@selector(refreshActionCalled:) forControlEvents:UIControlEventValueChanged];
@@ -182,6 +167,20 @@ - (void)showViewSelector:(UIBarButtonItem *)sender {
182167
[self presentViewController:nc animated:YES completion:NULL];
183168
}
184169

170+
#pragma mark Search bar delegate
171+
172+
- (void)filterSearchResultsWithSearchString:(NSString *)searchString {
173+
NSMutableArray *arr = [NSMutableArray array];
174+
175+
for (FTAPIJobDataObject *job in _serverObject.jobs) {
176+
NSRange isRange = [job.name rangeOfString:searchString options:NSCaseInsensitiveSearch];
177+
if (isRange.location != NSNotFound) {
178+
[arr addObject:job];
179+
}
180+
}
181+
_searchResults = arr;
182+
}
183+
185184
#pragma mark Table view delegate and data source methods
186185

187186
- (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
@@ -194,12 +193,12 @@ - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
194193
- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {
195194
if (tableView == self.tableView) {
196195
if ([self isJobsSection:section]) {
197-
return [self.jobs count];
196+
return [_jobs count];
198197
}
199198
else return 3;
200199
}
201200
else {
202-
return [self.searchResults count];
201+
return [_searchResults count];
203202
}
204203
}
205204

@@ -325,7 +324,7 @@ - (FTIconCell *)iconCellForRowAtIndexPath:(NSIndexPath *)indexPath {
325324
[cell.iconView setDefaultIconIdentifier:@"icon-cogs"];
326325
[cell.textLabel setText:FTLangGet(@"Manage Jenkins")];
327326
// TODO: Decide if the manage section is only for logged in users!
328-
if ((dAccountsManager.selectedAccount.username && dAccountsManager.selectedAccount.username.length > 0) || YES) {
327+
if (([FTAccountsManager sharedManager].selectedAccount.username && [FTAccountsManager sharedManager].selectedAccount.username.length > 0) || YES) {
329328
[cell setAccessoryType:UITableViewCellAccessoryDisclosureIndicator];
330329
[cell setSelectionStyle:UITableViewCellSelectionStyleDefault];
331330
[cell.iconView setAlpha:1];
@@ -355,7 +354,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
355354
return [self iconCellForRowAtIndexPath:indexPath];
356355
}
357356
}
358-
else if ([self.jobs count] == 0) {
357+
else if ([_jobs count] == 0) {
359358
return [self cellForNoJob];
360359
}
361360
else {
@@ -463,7 +462,7 @@ - (FTAPIJobDataObject *)jobAtIndexPath:(NSIndexPath *)indexPath inTableView:(UIT
463462
return nil;
464463
}
465464

466-
NSArray *dataSource = (tableView == self.tableView ? self.jobs : self.searchResults);
465+
NSArray *dataSource = (tableView == self.tableView ? _jobs : _searchResults);
467466
NSUInteger dataCount = [dataSource count];
468467

469468
if (dataCount > 0 && indexPath.row < dataCount) {

iJenkins/FTUserDetailViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ - (void)setupView {
112112
#pragma mark Tableview delegate & datasource methods
113113

114114
- (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
115-
return (_isLoading || [_nickName isEqualToString:dAccountsManager.selectedAccount.username]) ? 1 : 2;
115+
return (_isLoading || [_nickName isEqualToString:[FTAccountsManager sharedManager].selectedAccount.username]) ? 1 : 2;
116116
}
117117

118118
- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {

0 commit comments

Comments
 (0)