Skip to content

Commit 05d081f

Browse files
committed
Revert "data_share: Emit barrier before reads"
This reverts commit 7b24b42.
1 parent 268927b commit 05d081f

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/shader_recompiler/frontend/translate/data_share.cpp

-8
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
// SPDX-FileCopyrightText: Copyright 2024 shadPS4 Emulator Project
22
// SPDX-License-Identifier: GPL-2.0-or-later
3-
43
#include "shader_recompiler/frontend/translate/translate.h"
54
#include "shader_recompiler/ir/reg.h"
6-
#include "shader_recompiler/profile.h"
75
#include "shader_recompiler/runtime_info.h"
86

97
namespace Shader::Gcn {
@@ -205,7 +203,6 @@ void Translator::DS_WRITE(int bit_size, bool is_signed, bool is_pair, bool strid
205203
addr, ir.Imm32((u32(inst.control.ds.offset1) << 8u) + u32(inst.control.ds.offset0)));
206204
ir.WriteShared(bit_size, ir.GetVectorReg(data0), addr0);
207205
}
208-
emit_ds_read_barrier = true;
209206
}
210207

211208
void Translator::DS_SWIZZLE_B32(const GcnInst& inst) {
@@ -222,11 +219,6 @@ void Translator::DS_SWIZZLE_B32(const GcnInst& inst) {
222219

223220
void Translator::DS_READ(int bit_size, bool is_signed, bool is_pair, bool stride64,
224221
const GcnInst& inst) {
225-
if (emit_ds_read_barrier && profile.needs_lds_barriers) {
226-
ir.Barrier();
227-
emit_ds_read_barrier = false;
228-
}
229-
230222
const IR::U32 addr{ir.GetVectorReg(IR::VectorReg(inst.src[0].code))};
231223
IR::VectorReg dst_reg{inst.dst[0].code};
232224
if (is_pair) {

src/shader_recompiler/frontend/translate/translate.h

-1
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,6 @@ class Translator {
308308
const RuntimeInfo& runtime_info;
309309
const Profile& profile;
310310
bool opcode_missing = false;
311-
bool emit_ds_read_barrier = false;
312311
};
313312

314313
void Translate(IR::Block* block, u32 block_base, std::span<const GcnInst> inst_list, Info& info,

0 commit comments

Comments
 (0)