gitlab-runner: add authenticationTokenConfigFile #1321
+216
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in nixpkgs#356717, `gitlab-runner` now uses TOML date-time values in its configuration (namely the `token_obtained_at` and `token_expires_at` keys). As there is no JSON syntax for such values, remarshal refuses to serialise them without the `--stringify` flag. Thankfully, `gitlab-runner` seems to accept the stringified values without any complaints, so we can side-step this issue readily.
|
I am using this in the GHC AArch64/Darwin CI pool. It appears to work well. Backport to 24.11 would be appreciated. |
|
Can you rebase this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab is deprecating the original token-based runner authentication method as noted in https://docs.gitlab.com/ee/security/tokens/index.html#runner-authentication-tokens.
Based on #1185.