Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Center: Add missing Options, and Fix some #1347

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Iamanaws
Copy link

No description provided.

- Added new options for AccessibilityShortcuts, Battery (enum mode), Hearing, KeyboardBrightness, MusicRecognition, and updated UserSwitcher.
- Updated existing options (Display, FocusModes, NowPlaying, ScreenMirroring, Sound) to use enum types with refined mapping values.
@Iamanaws
Copy link
Author

I just have doubt about the options that change their type, I know there are ways, but here I'm not sure how to add a warning or heads up, to indicate the allowed values had changed

Copy link
Contributor

@bew bew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the options ;)

For the type change, we could have backward compatibility with warning by adding true & false in the mkXXXXApply mapping functions like:

mkEnumApply {
  always = 21,
  hide = 42,
  true = lib.warn ''something something use "always" now'' 21,
  false = lib.warn ''something something use `"hide"` now'' 42,
}

@Iamanaws Iamanaws force-pushed the controlcenter branch 13 times, most recently from ae9a1fa to 969cca6 Compare February 23, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants