Fixed the access to an uninitialized variable when using PhotonGI caustic cache alone

Author: Dade916

release-notes.txt

@@ -71,6 +71,7 @@
 * Fixed a problem with caustic cache size when both PhotonGI caches were
   enabled and automatic stop condition for indirect cache was used
 * PhotonGI Metropolis will now focus on caustic cache when indirect is done (and vice versa)
+* Fixed the access to an uninitialized variable when using PhotonGI caustic cache alone
 
 Check https://wiki.luxcorerender.org/LuxCoreRender_Release_Notes for the full list
 of release notes.

src/slg/engines/caches/photongi/photongicache.cpp

@@ -62,7 +62,10 @@ bool PhotonGICache::IsPhotonGIEnabled(const BSDF &bsdf) const {
 	const BSDFEvent eventTypes = bsdf.GetEventTypes();
 
 	if ((eventTypes & TRANSMIT) || (eventTypes & SPECULAR) ||
-			((eventTypes & GLOSSY) && (bsdf.GetGlossiness() < params.indirect.glossinessUsageThreshold)))
+			// Note: params.indirect.glossinessUsageThreshold is not initialized
+			// if indirect cache is not enabled
+			((eventTypes & GLOSSY) && (params.indirect.enabled) &&
+			(bsdf.GetGlossiness() < params.indirect.glossinessUsageThreshold)))
 		return false;
 	else
 		return bsdf.IsPhotonGIEnabled();

tests/valgrind.suppress

@@ -148,6 +148,14 @@
    ...
 }
 
+{
+   libamdocl-orca64_cond1
+   Memcheck:Cond
+   ...
+   obj:*/libamdocl-orca64.so
+   ...
+}
+
 ################################################################################
 # AMD fglrx
 ################################################################################