Fixed a memory leak when rendering with OpenCL (noticeable when rendering animations)

Author: Dade916

release-notes.txt

@@ -28,6 +28,7 @@
 * Fixed a problem in glossy coating albedo evaluation on GPUs
 * Fixed a difference between CPU and GPU rendering when using a roughglass with a shadow transparency color
 * Fixed the support in .ply files for triangle AOVs
+* Fixed a memory leak when rendering with OpenCL (noticeable when rendering animations)
 
 Check https://wiki.luxcorerender.org/LuxCoreRender_Release_Notes for the full list
 of release notes.

scenes/cornell/cornell.cfg

@@ -17,7 +17,7 @@ path.photongi.indirect.enabled = 0
 #path.photongi.indirect.lookup.radius = 0.15
 #path.photongi.indirect.lookup.radius = 0.0
 #path.photongi.indirect.glossinessusagethreshold = 0.0
-#path.photongi.indirect.usagethresholdscale = 0.0
+#path.photongi.indirect.usagethresholdscale = 8.0
 #path.photongi.indirect.filter.radiusscale = 4.0
 path.photongi.caustic.enabled = 0
 #path.photongi.caustic.maxsize = 10000
@@ -55,9 +55,9 @@ film.imagepipelines.0.1.value = 2.2
 #film.imagepipelines.1.1.type = GAMMA_CORRECTION
 #film.imagepipelines.1.1.value = 2.2
 ## Optix denoiser
-film.imagepipelines.1.0.type = OPTIX_DENOISER
-film.imagepipelines.1.1.type = GAMMA_CORRECTION
-film.imagepipelines.1.1.value = 2.2
+#film.imagepipelines.1.0.type = OPTIX_DENOISER
+#film.imagepipelines.1.1.type = GAMMA_CORRECTION
+#film.imagepipelines.1.1.value = 2.2
 ##
 #film.imagepipelines.0.0.type = PATTERNS
 #film.imagepipelines.0.0.index = 0

scenes/cornell/cornell.scn

@@ -18,14 +18,20 @@ scene.camera.fieldofview = 39.1463
 scene.materials.Khaki.type = matte
 scene.materials.Khaki.kd = 1. 0.824176 0.549451
 ##
+#scene.materials.Khaki.type = glossy2
+#scene.materials.Khaki.kd = 0.75 0.75 0.75
+#scene.materials.Khaki.ks = 0.5 0.5 0.5
+#scene.materials.Khaki.uroughness = 0.06
+#scene.materials.Khaki.vroughness = 0.06
+############################
 scene.materials.HalveRed.type = matte
 scene.materials.HalveRed.kd = 0.70003 0. 0.
 ##
 #scene.materials.HalveRed.type = glossy2
-#scene.materials.HalveRed.kd = 0.75 0.75 0.75
+#scene.materials.HalveRed.kd = 0.75 0.0 0.0
 #scene.materials.HalveRed.ks = 0.5 0.5 0.5
-#scene.materials.HalveRed.uroughness = 0.21
-#scene.materials.HalveRed.vroughness = 0.21
+#scene.materials.HalveRed.uroughness = 0.06
+#scene.materials.HalveRed.vroughness = 0.06
 ##scene.materials.HalveRed.photongi.enable = 1
 ##
 #scene.materials.HalveRed.type = glossy2
@@ -66,8 +72,8 @@ scene.materials.DarkGreen.kd = 0. 0.4 0.
 #scene.materials.DarkGreen.type = glossy2
 #scene.materials.DarkGreen.kd = 0.0 0.0 0.0
 #scene.materials.DarkGreen.ks = 0.5 0.95 0.5
-#scene.materials.DarkGreen.uroughness = 0.051
-#scene.materials.DarkGreen.vroughness = 0.051
+#scene.materials.DarkGreen.uroughness = 0.06
+#scene.materials.DarkGreen.vroughness = 0.06
 #scene.materials.DarkGreen.photongi.enable = 1
 ##
 scene.materials.Light.type = matte

src/luxrays/accelerators/bvhaccelhw.cpp

@@ -236,6 +236,8 @@ class BVHKernel : public HardwareIntersectionKernel {
 		delete program;
 	}
 	virtual ~BVHKernel() {
+		delete kernel;
+
 		for (u_int i = 0; i < vertsBuffs.size(); ++i)
 			device.FreeBuffer(&vertsBuffs[i]);
 		for (u_int i = 0; i < nodeBuffs.size(); ++i)

src/luxrays/accelerators/mbvhaccelhw.cpp

@@ -270,6 +270,8 @@ class MBVHKernel : public HardwareIntersectionKernel {
 	}
 
 	virtual ~MBVHKernel() {
+		delete kernel;
+
 		for (u_int i = 0; i < vertsBuffs.size(); ++i)
 			device.FreeBuffer(&vertsBuffs[i]);
 		for (u_int i = 0; i < nodeBuffs.size(); ++i)

src/luxrays/accelerators/optixaccelhw.cpp

@@ -551,6 +551,8 @@ class OptixKernel : public HardwareIntersectionKernel {
 	virtual ~OptixKernel() {
 		CUDAIntersectionDevice *cudaDevice = dynamic_cast<CUDAIntersectionDevice *>(&device);
 
+		delete optixEmptyAccelKernel;
+
 		if (optixPipeline) {
 			CHECK_OPTIX_ERROR(optixPipelineDestroy(optixPipeline));
 		}

src/slg/scene/parsetextures.cpp

@@ -606,13 +606,13 @@ Texture *Scene::CreateTexture(const string &texName, const Properties &props) {
 		const float width = props.Get(Property(propName + ".width")(0.f)).Get<float>();
 
 		tex = new WireFrameTexture(width, bordertTex, insideTex);
-	} else if (texType == "bevel") {
+	/*} else if (texType == "bevel") {
 		const Texture *bumpTex = props.IsDefined(propName + ".bumptex") ?
 			GetTexture(props.Get(Property(propName + ".bumptex")(1.f))) : nullptr;
 		
 		const float radius = props.Get(Property(propName + ".radius")(.025f)).Get<float>();
 
-		tex = new BevelTexture(bumpTex, radius);
+		tex = new BevelTexture(bumpTex, radius);*/
 	} else
 		throw runtime_error("Unknown texture type: " + texType);
 

tests/pymemoryleaktest/pymemoryleaktest.py

@@ -50,15 +50,18 @@ def SceneOps():
 	scene = pyluxcore.Scene("scenes/luxball/luxball-hdr.scn", 1.0)
 
 def RenderConfigOps():
-	renderConfig = pyluxcore.Scene("scenes/luxball/luxball-hdr.cfg", 1.0)
+	props = pyluxcore.Properties("scenes/luxball/luxball-hdr.cfg")
+	config = pyluxcore.RenderConfig(props)
 
 def SimpleRender():
 	# Load the configuration from file
 	props = pyluxcore.Properties("scenes/luxball/luxball-hdr.cfg")
 
-	# Change the render engine to PATHCPU
-	props.Set(pyluxcore.Property("renderengine.type", ["PATHCPU"]))
-	#props.Set(pyluxcore.Property("opencl.devices.select", ["0100"]))
+	# Change the render engine
+	props.Set(pyluxcore.Property("renderengine.type", ["PATHOCL"]))
+	props.Set(pyluxcore.Property("opencl.devices.select", ["01000"]))
+	props.Set(pyluxcore.Property("film.hw.enable", ["0"]))
+	props.Set(pyluxcore.Property("opencl.native.threads.count", [0]))
 
 	config = pyluxcore.RenderConfig(props)
 	session = pyluxcore.RenderSession(config)
@@ -78,15 +81,15 @@ def SimpleRender():
 	session.Stop()
 
 	# Save the rendered image
-	session.GetFilm().Save()
+	#session.GetFilm().Save()
 
 
 ################################################################################
 
 def MemoryUsage():
     import psutil
     process = psutil.Process(os.getpid())
-    mem = process.get_memory_info()[0]
+    mem = process.memory_info()[0]
     return mem
 
 def PropertiesTest():
@@ -169,9 +172,9 @@ def main():
 
 	print("LuxCore %s" % pyluxcore.Version())
 
-	PropertiesTest()
-	SceneTest()
-	RenderConfigTest()
+	#PropertiesTest()
+	#SceneTest()
+	#RenderConfigTest()
 	SimpleRenderTest()
 
 if __name__ == '__main__':