 modify this so it makes sense per trait currently everything defaults to 1 position 