Skip to content

Commit 9905a51

Browse files
committed
Normalize zip entries when reading and use pathSeparator where applicable.
1 parent 6f8a051 commit 9905a51

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/java/org/mcphackers/mcp/tasks/TaskRecompile.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ protected Stage[] setStages() {
8585
List<String> bootcp = new ArrayList<>();
8686
bootclasspath.forEach(p -> bootcp.add(p.toAbsolutePath().toString()));
8787
if (!bootclasspath.isEmpty()) {
88-
options.addAll(Arrays.asList("-bootclasspath", String.join(System.getProperty("path.separator"), bootcp)));
88+
options.addAll(Arrays.asList("-bootclasspath", String.join(File.pathSeparator, bootcp)));
8989
}
9090

91-
options.addAll(Arrays.asList("-cp", String.join(System.getProperty("path.separator"), cp)));
91+
options.addAll(Arrays.asList("-cp", String.join(File.pathSeparator, cp)));
9292

9393
setProgress(3);
9494

src/main/java/org/mcphackers/mcp/tools/FileUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public static void extract(final InputStream zipFile, final Path destDir) throws
9696
try (ZipInputStream zipInputStream = new ZipInputStream(zipFile)) {
9797
ZipEntry entry;
9898
while ((entry = zipInputStream.getNextEntry()) != null) {
99-
Path toPath = destDir.resolve(entry.getName());
99+
Path toPath = destDir.resolve(entry.getName()).normalize();
100100
Files.deleteIfExists(toPath);
101101
if (!entry.isDirectory()) {
102102
createDirectories(toPath.getParent());
@@ -115,7 +115,7 @@ public static void extract(final Path zipFile, final Path destDir, Function<ZipE
115115
try (ZipInputStream zipInputStream = new ZipInputStream(Files.newInputStream(zipFile))) {
116116
ZipEntry entry;
117117
while ((entry = zipInputStream.getNextEntry()) != null) {
118-
Path toPath = destDir.resolve(entry.getName());
118+
Path toPath = destDir.resolve(entry.getName()).normalize();
119119
Files.deleteIfExists(toPath);
120120
if (match.apply(entry)) {
121121
if (!entry.isDirectory()) {

0 commit comments

Comments
 (0)