[Bug] GNB - No Mercy conflict

[Rubyurek]

Describe the bug
A clear and concise description of what the bug is.
When you combine Sonic Break and Double Down with No Mercy, the problem arises that after “No Mercy” is displayed very briefly, “Sonic Break” appears but immediately switches to “Double Down.” This means that you then have no opportunity to use Sonic Break. No Mercy is officially linked to Sonic Break, but this conflict arises.

To Reproduce
Please try to submit as much information as possible to reproduce the behavior:

1. Which plugin version you have - XIV Combo Expanded v2.0.5.0
2. Which job is affected - GNB
3. What are your enabled combos for that job - No Mercy always Double Down Feature
4. Which skill is placed in your hotbar - No Mercy
5. Are you using any other XIVCombo fork? because you shouldn't - No

Expected behavior
A clear and concise description of what you expected to happen. - Described quite well under "Describe the bug."

Screenshots or videos
If applicable, add screenshots/videos to help explain your problem.
https://streamable.com/3ljhnx

[kaedys]

Looking at the logic, No Mercy has the following replacement conditions:

• If No Mercy Double Down Feature is enabled, level is >= 90, No Mercy buff is active, ammo >= 1, and Double Down is off cooldown, use Double Down.
• If No Mercy Always Double Down Feature is enabled and No Mercy buff is active, use Double Down.
• If No Mercy Bow Shock is enabled, level is >= 62, No Mercy buff is active, and Bow Shock is off cooldown:
  • If Ready To Break buff is active and the GCD is not active, use Solid Break
  • Else, use Bow Shock

So the only thing that should be able to cause your specific issue is if you have the No Mercy Always Double Down Feature combo enabled (which is an Accessibility level combo), rather than the Secret-level No Mercy Double Down Feature combo. If you do not see the latter, ensure you have Secret level combos set to display in the plugin options.

However, I do see several bugs in this:

• No Mercy Always Double Down Feature conflicts with No Mercy Bow Shock, so you shouldn't be able to have both active at once.
• Double Down requires 2 ammo, not 1, so the conditional for its use needs to be adjusted.
• There are several redundant level checks for No Mercy's level that do not need to happen, since every conditional in the block also checks for a higher level.
• No Mercy Bow Shock does not indicate that it also places Sonic Break on No Mercy. This should be a separate option or sub option, not an undocumented inclusion.
• No Mercy Double Down Feature and No Mercy Always Double Down Feature should conflict, or No Mercy Double Down Feature should be a sub-combo that improves the replacement logic. Currently both could be enabled, which is redundant, as No Mercy Always Double Down Feature applies in all situations the other one does, plus several.

[MKhayle]

GNB as a whole needs an entire rework, it's wonky for sure