We want to make contributing to this project as easy and transparent as possible.
We use GitHub to sync code to and from our internal repository. We'll use GitHub to track issues and feature requests, as well as accept pull requests.
We use GitHub issues to track public bugs. Please ensure your description is clear and has sufficient instructions to be able to reproduce the issue.
Report bugs using Github's issues
We use GitHub issues to track public bugs. Report a bug by opening a new issue; it's that easy!
We actively welcome your pull requests.
- Fork the repo and create your branch from
master
. - If you've added code that should be tested, add tests.
- If you've changed APIs, update the documentation.
- Ensure the test suite passes.
- Make sure your code lints.
- Issue that pull request!
In short, when you submit code changes, your submissions are understood to be under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
-
Write code compatible with C++98
-
Use underscore (
_variable
) in the name of a class member variable. -
C++98 does not allow me to use constructor delegation. Using methods like
setAllPointersToNull()
to make up for it. -
Order of methods in a class definition:
- functional (calculation, helpers etc)
- getters/setters
- disp()
- constructors/destructors
-
In copy constructors copy primitive types, set all pointers to zero.
- Folow conventional commits recommendations. A cheetsheet is here.
By contributing to Draft.js, you agree that your contributions will be licensed under its BSD license.
This document was adapted from the open-source contribution guidelines for Facebook's Draft and qMRLab.