Skip to content

Commit 3e56f95

Browse files
ykztsGargron
authored andcommitted
Replace from scss-lint to sass-lint (#10958)
1 parent 3f536f0 commit 3e56f95

7 files changed

+442
-35
lines changed

.codeclimate.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ plugins:
3131
rubocop:
3232
enabled: true
3333
channel: rubocop-0-71
34-
scss-lint:
34+
sass-lint:
3535
enabled: true
3636
exclude_patterns:
3737
- spec/

.scss-lint.yml .sass-lint.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Linter Documentation:
2-
# https://github.com/brigade/scss-lint/blob/v0.42.2/lib/scss_lint/linter/README.md
2+
# https://github.com/sasstools/sass-lint/tree/v1.13.1/docs/options
33

4-
scss_files: 'app/javascript/styles/**/*.scss'
5-
6-
exclude:
7-
- app/javascript/styles/reset.scss
4+
files:
5+
include: app/javascript/styles/**/*.scss
6+
ignore:
7+
- app/javascript/styles/reset.scss
88

99
linters:
1010
# Reports when you use improper spacing around ! (the "bang") in !default,

.yarnclean

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ Gruntfile.js
4343

4444
# for specific ignore
4545
!.svgo.yml
46-
46+
!sass-lint/**/*.yml

Gemfile

-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ group :development do
132132
gem 'rubocop-rails', '~> 2.0', require: false
133133
gem 'brakeman', '~> 4.5', require: false
134134
gem 'bundler-audit', '~> 0.6', require: false
135-
gem 'scss_lint', '~> 0.58', require: false
136135

137136
gem 'capistrano', '~> 3.11'
138137
gem 'capistrano-rails', '~> 1.4'

Gemfile.lock

-12
Original file line numberDiff line numberDiff line change
@@ -470,9 +470,6 @@ GEM
470470
thor (>= 0.19.0, < 2.0)
471471
rainbow (3.0.0)
472472
rake (12.3.2)
473-
rb-fsevent (0.10.3)
474-
rb-inotify (0.10.0)
475-
ffi (~> 1.0)
476473
rdf (3.0.9)
477474
hamster (~> 3.0)
478475
link_header (~> 0.0, >= 0.0.8)
@@ -547,14 +544,6 @@ GEM
547544
crass (~> 1.0.2)
548545
nokogiri (>= 1.8.0)
549546
nokogumbo (~> 2.0)
550-
sass (3.7.4)
551-
sass-listen (~> 4.0.0)
552-
sass-listen (4.0.0)
553-
rb-fsevent (~> 0.9, >= 0.9.4)
554-
rb-inotify (~> 0.9, >= 0.9.7)
555-
scss_lint (0.58.0)
556-
rake (>= 0.9, < 13)
557-
sass (~> 3.5, >= 3.5.5)
558547
sidekiq (5.2.7)
559548
connection_pool (~> 2.2, >= 2.2.2)
560549
rack (>= 1.5.0)
@@ -751,7 +740,6 @@ DEPENDENCIES
751740
rubocop (~> 0.71)
752741
rubocop-rails (~> 2.0)
753742
sanitize (~> 5.0)
754-
scss_lint (~> 0.58)
755743
sidekiq (~> 5.2)
756744
sidekiq-bulk (~> 0.2.0)
757745
sidekiq-scheduler (~> 3.0)

package.json

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"start": "node ./streaming/index.js",
1313
"test": "${npm_execpath} run test:lint && ${npm_execpath} run test:jest",
1414
"test:lint": "eslint --ext=js .",
15+
"test:lint:sass": "sass-lint .",
1516
"test:jest": "cross-env NODE_ENV=test jest --coverage"
1617
},
1718
"repository": {
@@ -177,6 +178,7 @@
177178
"raf": "^3.4.1",
178179
"react-intl-translations-manager": "^5.0.3",
179180
"react-test-renderer": "^16.8.6",
181+
"sass-lint": "^1.13.1",
180182
"webpack-dev-server": "^3.5.1",
181183
"yargs": "^12.0.5"
182184
}

0 commit comments

Comments
 (0)