Skip to content

Log In button does not get disabled after submit is clicked #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobioboye opened this issue Mar 10, 2012 · 2 comments
Closed

Log In button does not get disabled after submit is clicked #707

tobioboye opened this issue Mar 10, 2012 · 2 comments
Milestone

Comments

@tobioboye
Copy link
Member

This is related to issue #641. The log in button on the main page and that of role switching not being disabled when logging in.

A fix was pushed already but it involved modifying the Prototype framework AJAX after event handler. The checked in fix changed the AJAX after handler to be a complete handler. This does not change any functionality as the current AJAX after handler only enables the button and sets it to it's original value. However, it should be cleaned up with a new release of Prototype.

A Using an AJAX after handler as is used currently by the rails.js file is wrong and a reference to using AJAX complete can be found at rails/prototype-ujs#5

A discussion on the Markus Blog was opened at http://blog.markusproject.org/?p=3631

@ghost ghost assigned ghigt May 19, 2013
@ghigt
Copy link
Member

ghigt commented Jun 14, 2013

I think, that has been done.

But there is still a little problem when we use the modal connection which enable the submit button before the modal close.

@arkon
Copy link
Contributor

arkon commented May 26, 2014

See PR #1478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants