style: fix no-useless-escape rule violations

Author: ssimek

eslint.config.mjs

@@ -73,7 +73,6 @@ export default tseslint.config(
             '@typescript-eslint/no-unsafe-return': 'off',               // 74 instances
             '@typescript-eslint/no-misused-promises': 'off',            // 53 instances
             '@typescript-eslint/no-floating-promises': 'off',           // 48 instances
-            'no-useless-escape': 'off',                                 // 38 instances
             'no-async-promise-executor': 'off',                         // 25 instances
             '@typescript-eslint/prefer-promise-reject-errors': 'off',   // 19 instances
             '@typescript-eslint/require-await': 'off',                  // 7 instances

src/backend/gdb_expansion.ts

@@ -1,8 +1,8 @@
 import { MINode } from './mi_parse';
 
-const resultRegex = /^([a-zA-Z_\-][a-zA-Z0-9_\-]*|\[\d+\])\s*=\s*/;
-const variableRegex = /^[a-zA-Z_\-][a-zA-Z0-9_\-]*/;
-const errorRegex = /^\<.+?\>/;
+const resultRegex = /^([a-zA-Z_-][a-zA-Z0-9_-]*|\[\d+\])\s*=\s*/;
+const variableRegex = /^[a-zA-Z_-][a-zA-Z0-9_-]*/;
+const errorRegex = /^<.+?>/;
 const referenceStringRegex = /^(0x[0-9a-fA-F]+\s*)"/;
 const referenceRegex = /^0x[0-9a-fA-F]+/;
 const nullpointerRegex = /^0x0+\b/;

src/backend/mi2/mi2.ts

@@ -32,7 +32,7 @@ export function escape(str: string) {
     return str.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
 }
 
-const nonOutput = /^(?:\d*|undefined)[\*\+\=]|[\~\@\&\^]/;
+const nonOutput = /^(?:\d*|undefined)[*+=]|[~@&^]/;
 const gdbMatch = /(?:\d*|undefined)\(gdb\)/;
 const numRegex = /\d+/;
 

src/backend/mi_parse.ts

@@ -62,7 +62,7 @@ export class MINode implements MIInfo {
         if (!start) {
             return undefined;
         }
-        const pathRegex = /^\.?([a-zA-Z_\-][a-zA-Z0-9_\-]*)/;
+        const pathRegex = /^\.?([a-zA-Z_-][a-zA-Z0-9_-]*)/;
         const indexRegex = /^\[(\d+)\](?:$|\.)/;
         path = path.trim();
         if (!path) { return start; }
@@ -136,11 +136,11 @@ export class MINode implements MIInfo {
 }
 
 const tokenRegex = /^\d+/;
-const outOfBandRecordRegex = /^(?:(\d*|undefined)([\*\+\=])|([\~\@\&]))/;
+const outOfBandRecordRegex = /^(?:(\d*|undefined)([*+=])|([~@&]))/;
 const resultRecordRegex = /^(\d*)\^(done|running|connected|error|exit)/;
 const newlineRegex = /^\r\n?/;
 const endRegex = /^\(gdb\)\r\n?/;
-const variableRegex = /^([a-zA-Z_\-][a-zA-Z0-9_\-]*)/;
+const variableRegex = /^([a-zA-Z_-][a-zA-Z0-9_-]*)/;
 const asyncClassRegex = /^(.*?),/;
 
 export function parseMI(output: string): MINode {

src/backend/symbols.ts

@@ -9,7 +9,7 @@ import { GDBDebugSession } from '../gdb';
 import { hexFormat } from '../frontend/utils';
 import { MINode } from './mi_parse';
 
-const OBJDUMP_SYMBOL_RE = RegExp(/^([0-9a-f]{8})\s([lg\ !])([w\ ])([C\ ])([W\ ])([I\ ])([dD\ ])([FfO\ ])\s(.*?)\t([0-9a-f]+)\s(.*)$/);
+const OBJDUMP_SYMBOL_RE = RegExp(/^([0-9a-f]{8})\s([lg !])([w ])([C ])([W ])([I ])([dD ])([FfO ])\s(.*?)\t([0-9a-f]+)\s(.*)$/);
 const NM_SYMBOL_RE = RegExp(/^([0-9a-f]+).*\t(.+):[0-9]+/);     // For now, we only need two things
 const debugConsoleLogging = false;
 const TYPE_MAP: { [id: string]: SymbolType } = {

src/common.ts

@@ -569,7 +569,7 @@ export function toStringDecHexOctBin(val: number /* should be an integer */): st
 export function parseHostPort(hostPort: string) {
     let port: number;
     let host = '127.0.0.1';
-    const match = hostPort.match(/(.*)\:([0-9]+)/);
+    const match = hostPort.match(/(.*):([0-9]+)/);
     if (match) {
         host = match[1] ? match[1] : host;
         port = parseInt(match[2], 10);
@@ -706,7 +706,7 @@ export class HrTimer {
 // where will need to put the string in quotes as a precaution. This is more a printing
 // aid rather an using for an API
 export function quoteShellAndCmdChars(s): string {
-    const quote = /[\s\"\*\[\]!@#$%^&*\(\)\\:]/g.test(s) ? '"' : '';
+    const quote = /[\s"*[\]!@#$%^&*()\\:]/g.test(s) ? '"' : '';
     s = s.replace(/"/g, '\\"').replace(/\\/g, '\\\\');
     return quote + s.replace(/"/g, '\\"') + quote;
 }

src/frontend/utils.ts

@@ -65,7 +65,7 @@ export function parseDimIndex(spec: string, count: number): string[] {
         return components;
     }
 
-    if (/^([0-9]+)\-([0-9]+)$/i.test(spec)) {
+    if (/^([0-9]+)-([0-9]+)$/i.test(spec)) {
         const parts = spec.split('-').map((p) => parseInteger(p));
         const start = parts[0];
         const end = parts[1];
@@ -83,7 +83,7 @@ export function parseDimIndex(spec: string, count: number): string[] {
         return components;
     }
 
-    if (/^[a-zA-Z]\-[a-zA-Z]$/.test(spec)) {
+    if (/^[a-zA-Z]-[a-zA-Z]$/.test(spec)) {
         const start = spec.charCodeAt(0);
         const end = spec.charCodeAt(2);