Skip to content

Commit f2f2c99

Browse files
committed
catalog: rename wire_compatible module to json_compatible
Moving the module rename into a separate commit to keep the diff clean.
1 parent cca5e13 commit f2f2c99

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

src/catalog/src/durable/upgrade.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@
6060
//!
6161
//! When in doubt, reach out to the Surfaces team, and we'll be more than happy to help :)
6262
63+
pub mod json_compatible;
6364
#[cfg(test)]
6465
mod tests;
65-
pub mod wire_compatible;
6666

6767
use mz_ore::{soft_assert_eq_or_log, soft_assert_ne_or_log};
6868
use mz_repr::Diff;

src/catalog/src/durable/upgrade/wire_compatible.rs renamed to src/catalog/src/durable/upgrade/json_compatible.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ macro_rules! json_compatible {
5353

5454
// SAFETY: Below we assert that these types are JSON compatible by generating arbitrary
5555
// structs, encoding in one, and then decoding in the other.
56-
unsafe impl $crate::durable::upgrade::wire_compatible::JsonCompatible< $b $(::$b_sub)* > for $a $(::$a_sub)* {}
57-
unsafe impl $crate::durable::upgrade::wire_compatible::JsonCompatible< $a $(::$a_sub)* > for $b $(::$b_sub)* {}
56+
unsafe impl $crate::durable::upgrade::json_compatible::JsonCompatible< $b $(::$b_sub)* > for $a $(::$a_sub)* {}
57+
unsafe impl $crate::durable::upgrade::json_compatible::JsonCompatible< $a $(::$a_sub)* > for $b $(::$b_sub)* {}
5858

5959
::paste::paste! {
6060
::proptest::proptest! {
@@ -72,7 +72,7 @@ macro_rules! json_compatible {
7272

7373
// Maybe superfluous, but this is a method called in production.
7474
let b_decoded = b_decoded.expect("asserted Ok");
75-
let b_converted: $b $(::$b_sub)* = $crate::durable::upgrade::wire_compatible::JsonCompatible::convert(&a);
75+
let b_converted: $b $(::$b_sub)* = $crate::durable::upgrade::json_compatible::JsonCompatible::convert(&a);
7676
assert_eq!(b_decoded, b_converted);
7777

7878
let b_bytes = ::serde_json::to_vec(&b_decoded).expect("JSON serializable");
@@ -88,7 +88,7 @@ macro_rules! json_compatible {
8888

8989
// Maybe superfluous, but this is a method called in production.
9090
let a_decoded = a_decoded.expect("asserted Ok");
91-
let a_converted: $a $(::$a_sub)* = $crate::durable::upgrade::wire_compatible::JsonCompatible::convert(&b);
91+
let a_converted: $a $(::$a_sub)* = $crate::durable::upgrade::json_compatible::JsonCompatible::convert(&b);
9292
assert_eq!(a_decoded, a_converted);
9393

9494
let a_bytes = ::serde_json::to_vec(&a_decoded).expect("JSON serializable");

src/catalog/src/durable/upgrade/v67_to_v68.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
use crate::durable::traits::{UpgradeFrom, UpgradeInto};
1111
use crate::durable::upgrade::MigrationAction;
12-
use crate::durable::upgrade::wire_compatible::{JsonCompatible, json_compatible};
12+
use crate::durable::upgrade::json_compatible::{JsonCompatible, json_compatible};
1313
use crate::durable::upgrade::{objects_v67 as v67, objects_v68 as v68};
1414

1515
json_compatible!(v67::GlobalId with v68::GlobalId);

src/catalog/src/durable/upgrade/v74_to_v75.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
use crate::durable::traits::{UpgradeFrom, UpgradeInto};
1111
use crate::durable::upgrade::MigrationAction;
12-
use crate::durable::upgrade::wire_compatible::{JsonCompatible, json_compatible};
12+
use crate::durable::upgrade::json_compatible::{JsonCompatible, json_compatible};
1313
use crate::durable::upgrade::{objects_v74 as v74, objects_v75 as v75};
1414

1515
json_compatible!(v74::ClusterReplicaKey with v75::ClusterReplicaKey);

src/catalog/src/durable/upgrade/v75_to_v76.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
use crate::durable::traits::{UpgradeFrom, UpgradeInto};
1111
use crate::durable::upgrade::MigrationAction;
12-
use crate::durable::upgrade::wire_compatible::{JsonCompatible, json_compatible};
12+
use crate::durable::upgrade::json_compatible::{JsonCompatible, json_compatible};
1313
use crate::durable::upgrade::{objects_v75 as v75, objects_v76 as v76};
1414

1515
json_compatible!(v75::ClusterKey with v76::ClusterKey);

0 commit comments

Comments
 (0)