Skip to content

Commit 2ebda31

Browse files
authored
Merge pull request #256 from Mathieu2301/hotfix/update_volume_indicator_versions
Hotfix/update volume indicator versions
2 parents 2ba221d + 29409bf commit 2ebda31

File tree

5 files changed

+27
-9
lines changed

5 files changed

+27
-9
lines changed

examples/BuiltInIndicator.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,15 @@ const TradingView = require('../main');
44
* This example tests built-in indicators like volume-based indicators
55
*/
66

7-
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-139!');
7+
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-241!');
88

9-
if (!process.argv[2] && !['VbPFixed@tv-basicstudies-139!', 'Volume@tv-basicstudies-144'].includes(volumeProfile.type)) {
9+
const AUTHENTICATED_INDICATORS = [
10+
'VbPFixed@tv-basicstudies-241',
11+
'VbPFixed@tv-basicstudies-241!',
12+
'Volume@tv-basicstudies-241',
13+
];
14+
15+
if (!process.argv[2] && !AUTHENTICATED_INDICATORS.includes(volumeProfile.type)) {
1016
throw Error('Please specify your \'sessionid\' cookie');
1117
}
1218

examples/ReplayMode.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,6 @@ async function addIndicator(name, pineId, options = {}) {
9191
});
9292
}
9393

94-
addIndicator('Volume', 'Volume@tv-basicstudies-144');
94+
addIndicator('Volume', 'Volume@tv-basicstudies-241');
9595
addIndicator('EMA_50', 'STD;EMA', { Length: 50 });
9696
addIndicator('EMA_200', 'STD;EMA', { Length: 200 });

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@mathieuc/tradingview",
3-
"version": "3.4.5",
3+
"version": "3.4.6",
44
"description": "Tradingview instant stocks API, indicator alerts, trading bot, and more !",
55
"main": "main.js",
66
"scripts": {

src/classes/BuiltInIndicator.js

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/**
2-
* @typedef {'Volume@tv-basicstudies-144'
3-
* | 'VbPFixed@tv-basicstudies-139!'
2+
* @typedef {'Volume@tv-basicstudies-241'
3+
* | 'VbPFixed@tv-basicstudies-241'
4+
* | 'VbPFixed@tv-basicstudies-241!'
45
* | 'VbPFixed@tv-volumebyprice-53!'
56
* | 'VbPSessions@tv-volumebyprice-53'
67
* | 'VbPSessionsRough@tv-volumebyprice-53!'
@@ -17,11 +18,22 @@
1718
*/
1819

1920
const defaultValues = {
20-
'Volume@tv-basicstudies-144': {
21+
'Volume@tv-basicstudies-241': {
2122
length: 20,
2223
col_prev_close: false,
2324
},
24-
'VbPFixed@tv-basicstudies-139!': {
25+
'VbPFixed@tv-basicstudies-241': {
26+
rowsLayout: 'Number Of Rows',
27+
rows: 24,
28+
volume: 'Up/Down',
29+
vaVolume: 70,
30+
subscribeRealtime: false,
31+
first_bar_time: NaN,
32+
last_bar_time: Date.now(),
33+
extendToRight: false,
34+
mapRightBoundaryToBarStartTime: true,
35+
},
36+
'VbPFixed@tv-basicstudies-241!': {
2537
rowsLayout: 'Number Of Rows',
2638
rows: 24,
2739
volume: 'Up/Down',

tests/builtInIndicator.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('BuiltInIndicator', () => {
3232
});
3333

3434
it('gets volume profile', async () => {
35-
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-139!');
35+
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-241!');
3636
volumeProfile.setOption('first_bar_time', Date.now() - 10 ** 8);
3737

3838
const VOL = new chart.Study(volumeProfile);

0 commit comments

Comments
 (0)