Skip to content

Commit 5eeebbe

Browse files
cvankeianhzo
authored andcommitted
clean up various L10n strings (Igalia#711)
* Fixes Igalia#648 Clean up various L10n strings and add new ones * Descriptions and key fixes * Add an item that we are going to need for Bookmarks * Updated the restart later description
1 parent 7c8b949 commit 5eeebbe

File tree

3 files changed

+390
-120
lines changed

3 files changed

+390
-120
lines changed

README.md

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ You can find us on Twitter [@MozillaReality](https://twitter.com/mozillareality)
1212
2. Click the `Firefox Reality for Android - Build - Master update →` link.
1313
3. Click the `Run Artifacts` tab, and click to download the APK for your platform of choice.
1414

15+
## L10n
16+
17+
Whenever a new string is added to a localizable strings file (strings.xml ,localpages.xml, ...) a string description must be provided as a comment above the new string. Also the project STRs wiki page must be updated with a key description, steps to reproduce and the expected results.
18+
The L10n wiki page can be found [here](https://github.com/MozillaReality/FirefoxReality/wiki/L10n).
19+
1520
## Setup instructions
1621

1722
*Make sure you are using Android NDK r17b.*

app/src/main/res/values/localpages.xml

+7-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,14 @@
33
- License, v. 2.0. If a copy of the MPL was not distributed with this
44
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
55
<resources>
6-
<!-- Private Browsing -->
6+
<!-- IMPORTANT NOTE: If this file is updated anyhow, the STRs wiki must be updated accordingly:
7+
https://github.com/MozillaReality/FirefoxReality/wiki/L10n -->
8+
9+
<!-- This string is used as the title of the Private Browsing page that is opened when the
10+
Private Browsing Mode button from the tray is clicked. -->
711
<string name="private_browsing_title">Private Browsing</string>
12+
<!-- This string is used as the body of the Private Browsing page that is opened when the
13+
Private Browsing Mode button from the tray is clicked. -->
814
<string name="private_browsing_body"><![CDATA[
915
<p>When you browse in a Private Window, %1$s <strong>does not save</strong>:</p>
1016
<ul class="two-column">

0 commit comments

Comments
 (0)