Factor out some common objects in the schemas #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@aaronsteers @edgarrmondragon is there no way to configure/bypass the sonar cloud tests? They've been pretty useless so far tbh... And there doesn't seem to be a way to change the duplication threshold. Thoughts? |
25 tasks
ericboucher
approved these changes
Apr 12, 2022
Contributor
Contributor
Author
|
Kudos, SonarCloud Quality Gate passed!
|
ericboucher
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
This PR cleans up the codebase a bit by creating reusable schema objects to represent some patterns found throughout the github API.
This should have no functional impact, but helps a bit with readability by removing a lot of redundant lines :)