Skip to content

docs/access-control-audit.md's refund "(at/after deadline)" row is stale — doesn't reflect the GRACE_PERIOD fix (#49) #170

Description

@chonilius

docs/access-control-audit.md's escrow table has a row: refund (at/after deadline) | Permissionless (deliberate) | none | unchanged | Match. This audit was written for #30, which closed before #49's fix landed — #49 ("release() has no deadline check — a sponsor can race permissionless refund() to steal back funds from an already-merged contributor") is what introduced GRACE_PERIOD (14 days). As implemented today, refund's permissionless path doesn't open "at/after deadline" at all — it opens at deadline + GRACE_PERIOD, per contracts/escrow/src/lib.rs's refund(): if now < escrow.deadline + GRACE_PERIOD { /* admin only */ }. The audit table's description of when this row's access level kicks in is now factually incorrect, not just incomplete (distinct from the separately-filed issue about this table missing rows for functions added after the audit — this is about an existing row's content being wrong). Update the row to say "at/after deadline + GRACE_PERIOD" and cross-reference #49.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentationhelp wantedExtra attention is neededspikeOpen-ended research/investigation task

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions