feat: add escrow to AcceptsScheme enum#766
Closed
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
Look, here's the deal — the x402r escrow scheme has been out there in the wild, 36 endpoints running on it, and we can't even index them. That's not hyperbole, folks. Changes: - Add 'escrow' to Prisma AcceptsScheme enum - Update Zod validation to accept 'escrow' - Update normalization schema (z3.literal → z3.enum) - Fix type cast in resources.ts - Add database migration Closes #663
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| @@ -0,0 +1,2 @@ | |||
| -- AlterEnum | |||
| ALTER TYPE "AcceptsScheme" ADD VALUE 'escrow'; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ALTER TYPE "AcceptsScheme" ADD VALUE 'escrow'; | |
| DO $ BEGIN | |
| ALTER TYPE "AcceptsScheme" ADD VALUE 'escrow'; | |
| EXCEPTION WHEN duplicate_object THEN null; | |
| END $; |
Migration fails with PostgreSQL error 42710 because the 'escrow' enum value already exists in the production database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
escrowas a valid payment scheme in x402scan. The x402r escrow scheme is live in production with 36 endpoints — this lets x402scan index them.Changes
escrowto PrismaAcceptsSchemeenum + migrationescrowz3.literal('exact')→z3.enum(['exact', 'escrow']))resources.tsTest Plan
exactscheme resources unaffected (additive enum change)Closes #663