Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Add test which validates only 1 request is sent to the Security Provider API #18615

Open
seaona opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
blocked team-confirmations-planning (only for internal use within Confirmations team)

Comments

@seaona
Copy link
Contributor

seaona commented Apr 17, 2023

Context: there has been an issue, where we sent additional requests to the Security Provider #18560 . This issue has been partially fixed by this PR #18598 and one more PR is pending in order to fix it completely.

What: add assertion in the security provider test, which validates that only 1 request is sent to the Security Provider API.

@seaona seaona added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 17, 2023
@seaona seaona self-assigned this Apr 17, 2023
@seaona seaona added the blocked label Jun 6, 2023
@bschorchit
Copy link

We'll be deprecating OpenSea's security provider once Blockaid's integration is ready. Should we de-prioritize this? cc: @seaona

@seaona
Copy link
Contributor Author

seaona commented Jun 20, 2023

yes, there is already a PR for the test, but the test won't pass because there was a pending task to solve on Security Provider code - since I think this won't be fixed as new prio is Blockaid, I guess this ticket and PR could be closed completely @bschorchit

@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked team-confirmations-planning (only for internal use within Confirmations team)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants