[e2e] Security provider improvements #18616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
|
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Context: there has been an issue, where we sent additional requests to the Security Provider #18560 . This issue has been partially fixed by this PR #18598
What: this PR adds new assertions to the e2e security provider tests, for making sure that only 1 request is sent to the security provider.
Since the additional requests were sent both whenever a signature was triggered as well as when the tx was Accepted/Rejected, in this PR we extend the actions to finish the flow, by accepting the signatures and at the end of the test we make sure only 1 request has been sent.
Screenshots/Screencaps
Whenever the remaining issue is fixed, this PR should pull last develop and tests should pass.
At the moment, tests fail, meaning tests are catching the extra requests.
Before
/
After
/
Manual Testing Steps
yarn test:e2e:single test/e2e/tests/security-provider.spec.js --browser=chromePre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.