Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: [Bug]: In the NFT view within the Send flow, the token assets are displayed only partially #29974

Closed
sleepytanya opened this issue Jan 29, 2025 · 0 comments · Fixed by #30036 or #30039
Closed

[Bug]: [Bug]: In the NFT view within the Send flow, the token assets are displayed only partially #29974

sleepytanya opened this issue Jan 29, 2025 · 0 comments · Fixed by #30036 or #30039
Assignees
@darkwing
Labels
regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-12.13.0 Issue or pull request that will be included in release 12.13.0 release-blocker This bug is blocking the next release sev-2 team-assets team-wallet-ux type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

In the NFT view within the Send flow, the token assets are displayed only partially, requiring users to scroll sideways to view all NFTs associated with their account.

Expected behavior

All NFT assets are fully visible or more easily navigable

Screenshots/Recordings

Screen.Recording.2025-01-29.at.11.18.58.mov

Steps to reproduce

  1. start Send flow
  2. Switch to NFT tab

Error messages or log output



Detection stage


During release testing


Version


12.11.0


Build type


None


Browser


Chrome, Firefox


Operating system


MacOS


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @sleepytanya
sleepytanya




            added
      

  regression-RC-12.11.0

  Regression bug that was found in release candidate (RC) for release 12.11.0

      

  release-blocker

  This bug is blocking the next release

      

  sev-2


      

  team-assets


      

  team-wallet-ux


      

  type-bug

  Something isn't working

  labels


      Jan 29, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Jan 29, 2025

    

  



  


  
    
  
  

    
  darkwing 

      added a commit
        to darkwing/metamask-extension
      that referenced
      this issue

    
      Jan 30, 2025
    
    

      


  

    

      


  

      
        @darkwing
  





      

        
          Fix MetaMask#29974 - Makes NFT list properly wrap within the send modal
        


      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          0dd9aa1
        
      

    

  




    

  




  

  

    
  


  

      

    @darkwing
darkwing



    mentioned this issue
    
      Jan 30, 2025
    





  


  

      
   Closed

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    


  


  
    
  
  

    
  darkwing 

      added a commit
      that referenced
      this issue

    
      Jan 30, 2025
    
    

      


  

    

      


  

      
        @darkwing
  





      

        
          Fix #29974 - Makes NFT list properly wrap within the send modal
        


      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          0dce8ba
        
      

    

  




    

  




  

  

    
  


  

      

    @dbrans
dbrans



    mentioned this issue
    
      Jan 31, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Jan 31, 2025
    
    

      


  

    

      


  

      
        @dbrans
      
        @darkwing
  





      

        
          fix: Makes NFT list properly wrap within the send modal (#30036)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          c3acb6f
        
      

    

  

    

      
## **Description**
- This is a non-fork mirror of @darkwing's PR:
#30005

Wraps the NFT list within the Send flow such that it will not overflow

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1)

## **Related issues**

Fixes: #29974

## **Manual testing steps**

1. Use an account with many NFTs
2. Start send flow
3. Click the AssetPicker, choose NFTs
4. See the wrapped NFTs

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<img width="521" alt="SCR-20250130-hbwm"
src="https://github.com/user-attachments/assets/abeb3b78-be50-4aa4-841f-f8441ba4103f"
/>



## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: David Walsh <[email protected]>

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Jan 31, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-12.13.0

  Issue or pull request that will be included in release 12.13.0
 label


      Jan 31, 2025

    

  



  


  
    
  
  

    
  dbrans 

      added a commit
      that referenced
      this issue

    
      Jan 31, 2025
    
    

      


  

    

      


  

      
        @dbrans
      
        @darkwing
  





      

        
          fix: Makes NFT list properly wrap within the send modal (#30036)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          fa70f0e
        
      

    

  

    

      
## **Description**
- This is a non-fork mirror of @darkwing's PR:
#30005

Wraps the NFT list within the Send flow such that it will not overflow

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1)

## **Related issues**

Fixes: #29974

## **Manual testing steps**

1. Use an account with many NFTs
2. Start send flow
3. Click the AssetPicker, choose NFTs
4. See the wrapped NFTs

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<img width="521" alt="SCR-20250130-hbwm"
src="https://github.com/user-attachments/assets/abeb3b78-be50-4aa4-841f-f8441ba4103f"
/>



## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: David Walsh <[email protected]>

    




    

  




  

  

    
  


  

      

    @dbrans
dbrans



    mentioned this issue
    
      Jan 31, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    14 tasks
  





  




  

  

    
  


  

    


      @dbrans
dbrans



        linked a pull request
        Jan 31, 2025
        that will
        close
        this issue





  

    
      cherry-pick(#30036): fix: Makes NFT list properly wrap within the send modal
      #30039
  



  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    14 tasks
  





  




  


  
    
  
  

    
  danjm 

      pushed a commit
      that referenced
      this issue

    
      Jan 31, 2025
    
    

      


  

    

      


  

      
        @dbrans
      
        @darkwing
  





      

        
          cherry-pick(#30036): fix: Makes NFT list properly wrap within the sen…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          0c48e70
        
      

    

  

    

      
…d modal (#30039)

## **Description**
- This is a non-fork mirror of @darkwing's PR:
#30005

Wraps the NFT list within the Send flow such that it will not overflow

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1)

## **Related issues**

Fixes: #29974

## **Manual testing steps**

1. Use an account with many NFTs
2. Start send flow
3. Click the AssetPicker, choose NFTs
4. See the wrapped NFTs

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<img width="521" alt="SCR-20250130-hbwm"

src="https://github.com/user-attachments/assets/abeb3b78-be50-4aa4-841f-f8441ba4103f"
/>



## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30039?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: David Walsh <[email protected]>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @darkwing
  
    darkwing
    

      








      


  


  

    Labels
  



    

      

    regression-RC-12.11.0

  Regression bug that was found in release candidate (RC) for release 12.11.0
  

    release-12.13.0

  Issue or pull request that will be included in release 12.13.0
  

    release-blocker

  This bug is blocking the next release
  

    sev-2

  

    team-assets

  

    team-wallet-ux

  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  



      

    

  
      

  

    

      3 participants
    

    

        
          @darkwing 
        
          @metamaskbot 
        
          @sleepytanya