Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create passthrough-keyring for Brave #4860

Open
danfinlay opened this issue Jul 23, 2018 · 0 comments
Open

Create passthrough-keyring for Brave #4860

danfinlay opened this issue Jul 23, 2018 · 0 comments
Labels
area-accounts Relating to how sensitive account data is managed and stored. browser-brave type-enhancement

Comments

@danfinlay
Copy link
Contributor

When running in Brave, should auto-detect a Geth instance running on localhost:8545 with unlocked accounts.

  • Should show any unlocked accounts as accounts in this passthrough keyring.
  • Should allow signing with these accounts.

Stretch goals:

  • Initialize account nicknames using RPC: db_getString, params: ['braveEthWallet', 'wallets']. Will return data of form: [{name: "Account 1", address: "0xabcdef…"}].
@danfinlay danfinlay added area-accounts Relating to how sensitive account data is managed and stored. browser-brave type-enhancement labels Jul 23, 2018
@bdresser bdresser added this to the Sprint 08 [7.23 - 8.3] milestone Jul 23, 2018
@bdresser bdresser modified the milestones: Sprint 08 [7.23 - 8.3], Sprint 09 [8.6 - 8.17] Aug 6, 2018
@bdresser bdresser modified the milestones: Sprint 09 [8.6 - 8.17], Sprint 10 [8.20 - 8.31] Aug 20, 2018
@bdresser bdresser removed this from the Sprint 10 [8.20 - 8.31] milestone Nov 21, 2018
@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@pedronfigueiredo pedronfigueiredo removed the stale issues and PRs marked as stale label Jul 20, 2023
@MetaMask MetaMask deleted a comment from github-actions bot Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accounts Relating to how sensitive account data is managed and stored. browser-brave type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants