Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Ignore Sandboxed iFrames #5116

Open
epiqueras opened this issue Aug 21, 2018 · 0 comments
Open

Should Ignore Sandboxed iFrames #5116

epiqueras opened this issue Aug 21, 2018 · 0 comments
Labels
type-enhancement type-security

Comments

@epiqueras
Copy link

What problem are you trying to solve?
Some dapps use sandboxed iframes to execute arbitrary code in a sandbox, (see https://www.w3schools.com/tags/att_iframe_sandbox.asp). MetaMask should not allow code in the sandbox to request transaction signing under any circumstances as users might believe the parent dapp is requesting it.

Describe the solution you'd like
MetaMask should block transactions originating from an iframe that has the sandbox attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement type-security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdresser @Gudahtt @epiqueras