Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Confirm Tx - Show parsed data when ABI is available #5610

Open
kumavis opened this issue Oct 25, 2018 · 0 comments
Open

UI - Confirm Tx - Show parsed data when ABI is available #5610

kumavis opened this issue Oct 25, 2018 · 0 comments
Labels
area-UI Relating to the user interface. T08-featureRequest

Comments

@kumavis
Copy link
Member

kumavis commented Oct 25, 2018 •
edited
Loading

On the Tx confirm screen in the data section we show (1) the relevant ABI and (2) the raw data

metamask confirm tx data

If we have the ABI then we should just show the raw data parsed with the ABI
e.g.

arg0: 0xabcd...
arg1: 0xabcd...
arg2: 42

We can specify the parameter names in ABIs but they will not always be there so we need to have fallbacks (e.g. arg0).
For addresses, could use fancy address display with identicon + copy tooltips
@kumavis kumavis added area-UI Relating to the user interface. T08-featureRequest labels Oct 25, 2018
@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 19, 2023
@pedronfigueiredo pedronfigueiredo removed the stale issues and PRs marked as stale label Jul 20, 2023
@MetaMask MetaMask deleted a comment from github-actions bot Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-UI Relating to the user interface. T08-featureRequest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumavis @pedronfigueiredo