Skip to content

[JitDiff X64] [prozolic] Improve ImmutableArrayExtensions.SequenceEqual #1519

@MihuBot

Description

@MihuBot

Job completed in 16 minutes 9 seconds (remote runner delay: 44 seconds).
dotnet/runtime#118932
Using arguments: -includeNewMethodRegressions -includeRemovedMethodImprovements

Diffs

Diffs
Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 41728031
Total bytes of diff: 41729012
Total bytes of delta: 981 (0.00 % of base)
Total relative delta: -5.67
    diff is a regression.
    relative diff is an improvement.


Total byte diff includes 3262 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had    8 unique methods,     3262 unique bytes

Top file regressions (bytes):
         981 : System.Collections.Immutable.dasm (0.05 % of base)

1 total files with Code Size differences (0 improved, 1 regressed), 259 unchanged.

Top method regressions (bytes):
         606 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[System.__Canon,System.__Canon](System.Collections.Immutable.ImmutableArray`1[System.__Canon],System.Collections.Generic.IEnumerable`1[System.__Canon],System.Collections.Generic.IEqualityComparer`1[System.__Canon]):bool (FullOpts) (0 base, 1 diff methods)
         417 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[System.Numerics.Vector`1[float],System.Numerics.Vector`1[float]](System.Collections.Immutable.ImmutableArray`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEqualityComparer`1[System.Numerics.Vector`1[float]]):bool (FullOpts) (0 base, 1 diff methods)
         377 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[System.Nullable`1[int],System.Nullable`1[int]](System.Collections.Immutable.ImmutableArray`1[System.Nullable`1[int]],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]],System.Collections.Generic.IEqualityComparer`1[System.Nullable`1[int]]):bool (FullOpts) (0 base, 1 diff methods)
         375 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[double,double](System.Collections.Immutable.ImmutableArray`1[double],System.Collections.Generic.IEnumerable`1[double],System.Collections.Generic.IEqualityComparer`1[double]):bool (FullOpts) (0 base, 1 diff methods)
         372 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[byte,byte](System.Collections.Immutable.ImmutableArray`1[byte],System.Collections.Generic.IEnumerable`1[byte],System.Collections.Generic.IEqualityComparer`1[byte]):bool (FullOpts) (0 base, 1 diff methods)
         372 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[long,long](System.Collections.Immutable.ImmutableArray`1[long],System.Collections.Generic.IEnumerable`1[long],System.Collections.Generic.IEqualityComparer`1[long]):bool (FullOpts) (0 base, 1 diff methods)
         372 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[short,short](System.Collections.Immutable.ImmutableArray`1[short],System.Collections.Generic.IEnumerable`1[short],System.Collections.Generic.IEqualityComparer`1[short]):bool (FullOpts) (0 base, 1 diff methods)
         371 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[int,int](System.Collections.Immutable.ImmutableArray`1[int],System.Collections.Generic.IEnumerable`1[int],System.Collections.Generic.IEqualityComparer`1[int]):bool (FullOpts) (0 base, 1 diff methods)

Top method improvements (bytes):
        -339 (-55.94 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[System.__Canon,System.__Canon](System.Collections.Immutable.ImmutableArray`1[System.__Canon],System.Collections.Generic.IEnumerable`1[System.__Canon],System.Collections.Generic.IEqualityComparer`1[System.__Canon]):bool (FullOpts)
        -315 (-75.54 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[System.Numerics.Vector`1[float],System.Numerics.Vector`1[float]](System.Collections.Immutable.ImmutableArray`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEqualityComparer`1[System.Numerics.Vector`1[float]]):bool (FullOpts)
        -275 (-72.94 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[System.Nullable`1[int],System.Nullable`1[int]](System.Collections.Immutable.ImmutableArray`1[System.Nullable`1[int]],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]],System.Collections.Generic.IEqualityComparer`1[System.Nullable`1[int]]):bool (FullOpts)
        -273 (-72.80 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[double,double](System.Collections.Immutable.ImmutableArray`1[double],System.Collections.Generic.IEnumerable`1[double],System.Collections.Generic.IEqualityComparer`1[double]):bool (FullOpts)
        -270 (-72.58 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[byte,byte](System.Collections.Immutable.ImmutableArray`1[byte],System.Collections.Generic.IEnumerable`1[byte],System.Collections.Generic.IEqualityComparer`1[byte]):bool (FullOpts)
        -270 (-72.58 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[long,long](System.Collections.Immutable.ImmutableArray`1[long],System.Collections.Generic.IEnumerable`1[long],System.Collections.Generic.IEqualityComparer`1[long]):bool (FullOpts)
        -270 (-72.58 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[short,short](System.Collections.Immutable.ImmutableArray`1[short],System.Collections.Generic.IEnumerable`1[short],System.Collections.Generic.IEqualityComparer`1[short]):bool (FullOpts)
        -269 (-72.51 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[int,int](System.Collections.Immutable.ImmutableArray`1[int],System.Collections.Generic.IEnumerable`1[int],System.Collections.Generic.IEqualityComparer`1[int]):bool (FullOpts)

Top method regressions (percentages):
         372 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[byte,byte](System.Collections.Immutable.ImmutableArray`1[byte],System.Collections.Generic.IEnumerable`1[byte],System.Collections.Generic.IEqualityComparer`1[byte]):bool (FullOpts) (0 base, 1 diff methods)
         375 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[double,double](System.Collections.Immutable.ImmutableArray`1[double],System.Collections.Generic.IEnumerable`1[double],System.Collections.Generic.IEqualityComparer`1[double]):bool (FullOpts) (0 base, 1 diff methods)
         371 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[int,int](System.Collections.Immutable.ImmutableArray`1[int],System.Collections.Generic.IEnumerable`1[int],System.Collections.Generic.IEqualityComparer`1[int]):bool (FullOpts) (0 base, 1 diff methods)
         372 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[long,long](System.Collections.Immutable.ImmutableArray`1[long],System.Collections.Generic.IEnumerable`1[long],System.Collections.Generic.IEqualityComparer`1[long]):bool (FullOpts) (0 base, 1 diff methods)
         372 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[short,short](System.Collections.Immutable.ImmutableArray`1[short],System.Collections.Generic.IEnumerable`1[short],System.Collections.Generic.IEqualityComparer`1[short]):bool (FullOpts) (0 base, 1 diff methods)
         606 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[System.__Canon,System.__Canon](System.Collections.Immutable.ImmutableArray`1[System.__Canon],System.Collections.Generic.IEnumerable`1[System.__Canon],System.Collections.Generic.IEqualityComparer`1[System.__Canon]):bool (FullOpts) (0 base, 1 diff methods)
         377 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[System.Nullable`1[int],System.Nullable`1[int]](System.Collections.Immutable.ImmutableArray`1[System.Nullable`1[int]],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]],System.Collections.Generic.IEqualityComparer`1[System.Nullable`1[int]]):bool (FullOpts) (0 base, 1 diff methods)
         417 (Infinity of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:<SequenceEqual>g__Impl|7_0[System.Numerics.Vector`1[float],System.Numerics.Vector`1[float]](System.Collections.Immutable.ImmutableArray`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEqualityComparer`1[System.Numerics.Vector`1[float]]):bool (FullOpts) (0 base, 1 diff methods)

Top method improvements (percentages):
        -315 (-75.54 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[System.Numerics.Vector`1[float],System.Numerics.Vector`1[float]](System.Collections.Immutable.ImmutableArray`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]],System.Collections.Generic.IEqualityComparer`1[System.Numerics.Vector`1[float]]):bool (FullOpts)
        -275 (-72.94 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[System.Nullable`1[int],System.Nullable`1[int]](System.Collections.Immutable.ImmutableArray`1[System.Nullable`1[int]],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]],System.Collections.Generic.IEqualityComparer`1[System.Nullable`1[int]]):bool (FullOpts)
        -273 (-72.80 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[double,double](System.Collections.Immutable.ImmutableArray`1[double],System.Collections.Generic.IEnumerable`1[double],System.Collections.Generic.IEqualityComparer`1[double]):bool (FullOpts)
        -270 (-72.58 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[byte,byte](System.Collections.Immutable.ImmutableArray`1[byte],System.Collections.Generic.IEnumerable`1[byte],System.Collections.Generic.IEqualityComparer`1[byte]):bool (FullOpts)
        -270 (-72.58 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[long,long](System.Collections.Immutable.ImmutableArray`1[long],System.Collections.Generic.IEnumerable`1[long],System.Collections.Generic.IEqualityComparer`1[long]):bool (FullOpts)
        -270 (-72.58 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[short,short](System.Collections.Immutable.ImmutableArray`1[short],System.Collections.Generic.IEnumerable`1[short],System.Collections.Generic.IEqualityComparer`1[short]):bool (FullOpts)
        -269 (-72.51 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[int,int](System.Collections.Immutable.ImmutableArray`1[int],System.Collections.Generic.IEnumerable`1[int],System.Collections.Generic.IEqualityComparer`1[int]):bool (FullOpts)
        -339 (-55.94 % of base) : System.Collections.Immutable.dasm - System.Linq.ImmutableArrayExtensions:SequenceEqual[System.__Canon,System.__Canon](System.Collections.Immutable.ImmutableArray`1[System.__Canon],System.Collections.Generic.IEnumerable`1[System.__Canon],System.Collections.Generic.IEqualityComparer`1[System.__Canon]):bool (FullOpts)

16 total methods with Code Size differences (8 improved, 8 regressed), 250787 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions