Skip to content

[JitDiff X64] [prozolic] Replace signed comparisons with unsigned comparison ... #1584

@MihuBot

Description

@MihuBot

Job completed in 16 minutes 30 seconds (remote runner delay: 45 seconds).
dotnet/runtime#120877

Diffs

Found 85 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46022028
Total bytes of diff: 46022468
Total bytes of delta: 440 (0.00 % of base)
Total relative delta: 1.82
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
         287 : System.Reflection.Metadata.dasm (0.05 % of base)
         153 : System.Collections.Immutable.dasm (0.01 % of base)

2 total files with Code Size differences (0 improved, 2 regressed), 258 unchanged.

Top method regressions (bytes):
         287 (24.02 % of base) : System.Reflection.Metadata.dasm - System.Reflection.Metadata.Ecma335.MetadataBuilder:GetRowCounts():System.Collections.Immutable.ImmutableArray`1[int]:this (FullOpts)
          34 (30.09 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[System.__Canon]:MoveNext():bool:this (FullOpts)
          17 (18.89 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[byte]:MoveNext():bool:this (FullOpts)
          17 (18.28 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[double]:MoveNext():bool:this (FullOpts)
          17 (18.48 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[int]:MoveNext():bool:this (FullOpts)
          17 (18.68 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[long]:MoveNext():bool:this (FullOpts)
          17 (18.48 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[short]:MoveNext():bool:this (FullOpts)
          17 (18.68 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[System.Nullable`1[int]]:MoveNext():bool:this (FullOpts)
          17 (16.50 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[System.Numerics.Vector`1[float]]:MoveNext():bool:this (FullOpts)

Top method regressions (percentages):
          34 (30.09 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[System.__Canon]:MoveNext():bool:this (FullOpts)
         287 (24.02 % of base) : System.Reflection.Metadata.dasm - System.Reflection.Metadata.Ecma335.MetadataBuilder:GetRowCounts():System.Collections.Immutable.ImmutableArray`1[int]:this (FullOpts)
          17 (18.89 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[byte]:MoveNext():bool:this (FullOpts)
          17 (18.68 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[long]:MoveNext():bool:this (FullOpts)
          17 (18.68 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[System.Nullable`1[int]]:MoveNext():bool:this (FullOpts)
          17 (18.48 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[int]:MoveNext():bool:this (FullOpts)
          17 (18.48 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[short]:MoveNext():bool:this (FullOpts)
          17 (18.28 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[double]:MoveNext():bool:this (FullOpts)
          17 (16.50 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1+Builder+<GetEnumerator>d__66[System.Numerics.Vector`1[float]]:MoveNext():bool:this (FullOpts)

9 total methods with Code Size differences (0 improved, 9 regressed), 282860 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions