Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #33

Closed
dlfivefifty opened this issue Apr 16, 2019 · 7 comments
Closed

Add documentation #33

dlfivefifty opened this issue Apr 16, 2019 · 7 comments

Comments

@dlfivefifty
Copy link
Contributor

There is almost no documentation or even code comments to explain what the code does. For example, I'm trying to use c_execute_tri_lo2hi but there is no explanation what basis the lo should be in.

@dlfivefifty
Copy link
Contributor Author

I managed to reverse-engineer it:

julia> P = c_plan_rottriangle(5, 0.,0.,0.);

julia> F = zeros(5,5); F[1,2] = 1; F
5×5 Array{Float64,2}:
 0.0  1.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0  0.0

julia> c_execute_tri_hi2lo(P, F); F
5×5 Array{Float64,2}:
 0.0   0.942809  0.0  0.0  0.0
 0.0  -0.333333  0.0  0.0  0.0
 0.0   0.0       0.0  0.0  0.0
 0.0   0.0       0.0  0.0  0.0
 0.0   0.0       0.0  0.0  0.0

julia> m,ℓ = 1,0;  Fun(t -> Fun(NormalizedJacobi(0,2m+1,0..1),[zeros(ℓ);1])(t) * 2^m*(1-t)^m, NormalizedJacobi(0,1,0..1))
Fun(NormalizedJacobi(0.0,1.0,0..1),[0.942809, -0.333333])

@MikaelSlevinsky
Copy link
Owner

I'm weighing all the different options for documentation such as: LaTeX, github.io, or the Wiki. LaTeX is good because it's lightweight (when the PDF isn't committed), but this may bloat the repository in time. Using GitHub.io is neat, but it will never look as good as what Documenter.jl produces for Julia packages. The automation behind the way it strips help text from package functions is great.

Maybe the best option is the wiki? It allows GitHub's flavour of markdown, which in turn allows html and thereby LaTeX for math. I don't think it add commits to the repository itself.

@MikaelSlevinsky
Copy link
Owner

Actually, looks like GitHub's markdown strips away scripts, so MathJax is probably off the table.

@dlfivefifty
Copy link
Contributor Author

The wiki is a bad idea, it’s hard to edit and it’s better to use something inside the version control.

@MikaelSlevinsky
Copy link
Owner

I might hold off for a bit. Nothing's settled at this point. For example, the signature of the computational kernel ft_kernel_tri_hi2lo may change to specify the hi and lo m values, not just assuming m down to 0. Let me know if there's anything that needs urgent explaining.

@MikaelSlevinsky
Copy link
Owner

What do you think? http://mikaelslevinsky.github.io/FastTransforms/ The mobile use chops some of the formulas off, but perhaps that will be fixed in time

@MikaelSlevinsky
Copy link
Owner

Now that the structure is there, more documentation can be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants