Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save beamWidthYerr in covariance matrix #2

Open
rmanzoni opened this issue Apr 28, 2015 · 0 comments
Open

Save beamWidthYerr in covariance matrix #2

rmanzoni opened this issue Apr 28, 2015 · 0 comments
Assignees
@menasce
Labels
enhancement

Comments

@rmanzoni
Copy link
Member

At the moment the covariance matrix only contains beamWidthXerr
https://github.com/MilanoBicocca-pix/cmssw/blob/CMSSW_7_5_X_beamspot_workflow_riccardo/RecoVertex/BeamSpotProducer/src/PVFitter.cc#L304
and, in the following
new: https://github.com/MilanoBicocca-pix/cmssw/blob/CMSSW_7_5_X_beamspot_workflow_riccardo/RecoVertex/BeamSpotProducer/python/workflow/objects/BeamSpotObj.py#L106
old: https://github.com/MilanoBicocca-pix/cmssw/blob/CMSSW_7_5_X_Minuit2/RecoVertex/BeamSpotProducer/scripts/CommonMethods.py#L419
we assume that beamWidthYerr == beamWidthYerr (which is fair, but in principle not entirely true).

Should we save beamWidthYerr as well? Code wise is trivial, but it may imply compatibility issues.

@sarafiorendi @menasce @rmanzoni @gennai
@rmanzoni rmanzoni assigned rmanzoni and menasce and unassigned rmanzoni Apr 28, 2015
rmanzoni pushed a commit that referenced this issue May 8, 2015
@pietverwilligen
Merge pull request #2 from cms-sw/CMSSW_7_5_X
6740e78 
PRToFixMess_RPCDigitizerForUpgrade75XPR_v2
rmanzoni pushed a commit that referenced this issue Jun 12, 2015
@ikrav
Merge pull request #2 from skyriacoCMS/patch-1
34203f9 
Update effAreaPhotons_cone03_pfNeutralHadrons_V2.txt
rmanzoni pushed a commit that referenced this issue Feb 3, 2017
@smorovic
fix indentation #2
806b470
rmanzoni pushed a commit that referenced this issue Feb 13, 2017
@Sam-Harper
Merge pull request #2 from rafaellopesdesa/Sam-Harper/GSIssueFix
c69575c 
thanks for getting this sorted
rmanzoni pushed a commit that referenced this issue Feb 13, 2017
@rafaellopesdesa
Merge pull request #2 from Sam-Harper/GSIssueFixPATcustomize
d60236a 
tighting the seed crystal matching
francescobrivio pushed a commit that referenced this issue Mar 8, 2019
@andrzejnovak
Merge pull request #2 from andrzejnovak/switch
3c81d7b 
Switch for Flavor  Description
francescobrivio pushed a commit that referenced this issue Apr 28, 2020
@duartej
Merge pull request #2 from mmusich/inclusionOf3DPixelsIntoCMSSW
0c1871c 
address remaining stylistic comments from code review
francescobrivio pushed a commit that referenced this issue Nov 13, 2020
@alefisico
Merge pull request #2 from alefisico/PUPPIMETwithPUPPIV15_v2
4b072e0 
fix bug
francescobrivio pushed a commit that referenced this issue Dec 7, 2020
@jsalfeld
Merge pull request #2 from mmasciov/mmasciovScoutingMuonRun3Format
72d1243 
Fix code formatting according to scram build code-format
francescobrivio pushed a commit that referenced this issue Dec 7, 2020
@lecriste
Merge pull request #2 from amartelli/timeForMerged_11_2_X_forLeo
6f18708 
Time for merged tracksters
francescobrivio pushed a commit that referenced this issue Nov 20, 2023
@dbruschi
Merge pull request #2 from cms-sw/master
26aee51 
Merge from cmssw master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@menasce menasce

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@menasce @rmanzoni