1.21.2-3 maintainance, external mods refresh, and misc optifabric update

[tildejustin]

sources:

• tildejustin/atum@840e662
• tildejustin/optifabric@b556a8c...legacy-fabric
• https://github.com/tildejustin/optifabric/tree/ornithe
• 1.21.2+ fix set-spawn#11
• tildejustin/planifolia@1.19+-sodium-0.4-0.5.x...1.21.1-sodium-0.6
• tildejustin/planifolia@aaca288
• port to 1.21.2+ RedLime/SleepBackground#23
• port to 1.21.3 contariaa/StandardSettings#25

[tildejustin]

will try to get around to testing this over the weekend

[contariaa]

Atum, StandardSettings and Planifolia look good.
Optifabric also looks fine, although I'm not too familiar with how it's supposed to look the code is mostly written by an outside contributor and as such I think we can consider justins review as the review from the tech advisor team.

I am wondering if there is meant to be a replacement for this deleted inject in SleepBackground, its not a critical issue or anything, but might be an oversight: https://github.com/RedLime/SleepBackground/pull/23/files#diff-48eaa3117ec88f1002ae1ca0401662c6876b5895144a0b3a7b5b590da197a98bL33-L38

Also I remember this being somewhere in javacord but it might be good to have the reasoning for disabling vanillas inactivity fps limiter written down somewhere official because i can no longer find it.
How does vanillas implementation differ from sleepbackgrounds, is there any advantages vanillas implementation has?

[contariaa]

Putting this here from discord so its documented, lgtm!

I am wondering if there is meant to be a replacement for this deleted inject in SleepBackground, its not a critical issue or anything, but might be an oversight: https://github.com/RedLime/SleepBackground/pull/23/files#diff-48eaa3117ec88f1002ae1ca0401662c6876b5895144a0b3a7b5b590da197a98bL33-L38

"in 1.21.2+ it was moved to PieChart, which is rendered in DebugHud, by InGameHud, finally from GameRenderer, which is already canceled via the same LATEST_LOCK_FRAME check so another mixin isn't necessary for that anymore" ~tildejustin

Also I remember this being somewhere in javacord but it might be good to have the reasoning for disabling vanillas inactivity fps limiter written down somewhere official because i can no longer find it.

"seems like fps limiting happens no matter if the player is in the world or not, so my vote would be to just disable its functionality and let sleepbg do what it does best...it hijacks the built in fps limiter to give a custom value under certain conditions"
"customizable, default 1 fps is better than 10"

[Knawk]

The changes since Contaria's approval look good to me.