Skip to content

Commit 87b1de4

Browse files
committed
upgrading to lodash v4. Closes ryanfitz#114
1 parent e4ae788 commit 87b1de4

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

lib/schema.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ var Schema = module.exports = function (config) {
9797
self.updatedAt = data.updatedAt;
9898

9999
if(data.indexes) {
100-
self.globalIndexes = _.chain(data.indexes).filter({ type: 'global' }).indexBy('name').value();
101-
self.secondaryIndexes = _.chain(data.indexes).filter({ type: 'local' }).indexBy('name').value();
100+
self.globalIndexes = _.chain(data.indexes).filter({ type: 'global' }).keyBy('name').value();
101+
self.secondaryIndexes = _.chain(data.indexes).filter({ type: 'local' }).keyBy('name').value();
102102
}
103103

104104
if(data.schema) {

lib/table.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ Table.prototype.update = function (item, options, callback) {
288288
delete options.expected;
289289
}
290290

291-
params = _.chain({}).merge(params, options).omit(_.isEmpty).value();
291+
params = _.chain({}).merge(params, options).omitBy(_.isEmpty).value();
292292

293293
self.sendRequest('update', params, function (err, data) {
294294
if(err) {
@@ -678,7 +678,7 @@ internals.findMissingGlobalIndexes = function (table, data) {
678678
return table.schema.globalIndexes;
679679
} else {
680680
var indexData = _.get(data, 'Table.GlobalSecondaryIndexes');
681-
var existingIndexNames = _.pluck(indexData, 'IndexName');
681+
var existingIndexNames = _.map(indexData, 'IndexName');
682682

683683
var missing = _.reduce(table.schema.globalIndexes, function (result, idx, indexName) {
684684
if (!_.includes(existingIndexNames, idx.name)) {

lib/utils.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ var _ = require('lodash'),
88
var utils = module.exports;
99

1010
utils.omitNulls = function (data) {
11-
return _.omit(data, function(value) {
11+
return _.omitBy(data, function(value) {
1212
return _.isNull(value) ||
1313
_.isUndefined(value) ||
1414
(_.isArray(value) && _.isEmpty(value)) ||

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"aws-sdk": "2.2.x",
2525
"bunyan": "1.5.x",
2626
"joi": "5.x.x",
27-
"lodash": "3.10.x",
27+
"lodash": "4.x.x",
2828
"node-uuid": "1.4.x"
2929
},
3030
"devDependencies": {

test/integration/integration-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ describe('Vogels Integration Tests', function() {
584584

585585
_.each(data.Items, function (t) {
586586
expect(t.get('UserId')).to.eql('userid-1');
587-
var c = _.contains([4, 6, 8], t.get('num'));
587+
var c = _.includes([4, 6, 8], t.get('num'));
588588
expect(c).to.be.true;
589589
});
590590

@@ -794,7 +794,7 @@ describe('Vogels Integration Tests', function() {
794794
expect(data.Items).to.have.length.above(0);
795795

796796
_.each(data.Items, function (u) {
797-
var c = _.contains([2, 9, 20], u.get('age'));
797+
var c = _.includes([2, 9, 20], u.get('age'));
798798
expect(c).to.be.true;
799799
});
800800

0 commit comments

Comments
 (0)