formatting, refactoring, add more warnings

Author: ModischFabrications

README.md

@@ -58,15 +58,18 @@ These were useful while refining the concept, check them out as well if you are
 
 1. https://github.com/ModischFabrications/HUB75-DMA-Test \* 
 1. https://github.com/ModischFabrications/Verdandi \* 
-2. https://2dom.github.io/PixelTimes/
-2. https://github.com/rorosaurus/esp32-hub75-driver
-3. https://github.com/witnessmenow/ESP32-i2s-Matrix-Shield
-3. https://www.instructables.com/Morphing-Digital-Clock/
-4. https://github.com/bogd/esp32-morphing-clock
-5. https://github.com/marcmerlin/AnimatedGIFs
-6. https://github.com/LukPopp0/MatrixDisplay
-7. https://randomnerdtutorials.com/esp32-touch-pins-arduino-ide/
-8. https://github.com/witnessmenow/ESP8266-Led-Matrix-Web-Draw
+1. https://2dom.github.io/PixelTimes/
+1. https://github.com/rorosaurus/esp32-hub75-driver
+1. https://github.com/witnessmenow/ESP32-i2s-Matrix-Shield
+1. https://www.instructables.com/Morphing-Digital-Clock/
+1. https://github.com/bogd/esp32-morphing-clock
+1. https://github.com/marcmerlin/AnimatedGIFs
+1. https://github.com/LukPopp0/MatrixDisplay
+1. https://randomnerdtutorials.com/esp32-touch-pins-arduino-ide/
+1. https://github.com/witnessmenow/ESP8266-Led-Matrix-Web-Draw
+1. https://arduinojson.org/v6/assistant/
+1. All the examples of the libraries mentioned above
+1. 
 
 \* Great guy, love him like myself. 
 

include/README

@@ -15,6 +15,8 @@ board = esp32doit-devkit-v1
 board_build.filesystem = littlefs
 board_build.partitions = no_ota.csv
 
+build_flags = -Wall
+
 upload_speed = 921600
 
 monitor_speed = 115200

lib/README

@@ -8,6 +8,8 @@
 #include <ESP32-HUB75-MatrixPanel-I2S-DMA.h> // https://github.com/mrfaptastic/ESP32-HUB75-MatrixPanel-I2S-DMA
 #include <FastLED.h>
 
+// manages screen initialization and some utility methods. Bypassable by more complex interactions.
+
 namespace Display {
 using namespace Pinout;
 
@@ -85,8 +87,6 @@ void flashScreen() {
     screen->clearScreen();
 }
 
-// TODO copy from Tests\animations.h
-
 void setup() {
     println(F("Starting matrix..."));
 

platformio.ini

@@ -61,7 +61,7 @@ void loop() {
     }
     logAllTouches();
     touched = NONE;
-    RebootManager::setActive();
+    RebootManager::reset();
 }
 
 } // namespace Input_Touch

src/display.h

@@ -5,13 +5,9 @@
 #include <Arduino.h>
 #include <ESPAsyncWebServer.h> // https://github.com/me-no-dev/ESPAsyncWebServer
 
-/**
- * /cmd?state=1
- *
- */
-
 namespace Website {
 
+namespace {
 AsyncWebServer server(80);
 
 void notFound(AsyncWebServerRequest* request) {
@@ -26,7 +22,7 @@ void GetRoot(AsyncWebServerRequest* request) {
 }
 
 void GetAPI(AsyncWebServerRequest* request) {
-    RebootManager::setActive();
+    RebootManager::reset();
 
     String message = F("Possible Commands, chain with \"&\":\n");
     message.reserve(200);
@@ -73,8 +69,8 @@ void GetAPI(AsyncWebServerRequest* request) {
     request->send(200, "text/plain", message);
     Display::flashDot();
 }
+} // namespace
 
-bool ready = false;
 // contract: WiFi must be enabled already
 void setup() {
     println(F("Preparing website"));
@@ -85,4 +81,6 @@ void setup() {
     server.begin();
 }
 
+void loop() {}
+
 } // namespace Website

src/inputs/touch.h

@@ -6,7 +6,7 @@
 #include "shared/weatherService.h"
 #include <Arduino.h>
 
-// maybe morph using https://github.com/hwiguna/HariFun_166_Morphing_Clock/blob/master/Latest/MorphingClock/Digit.cpp
+// TODO: this mode really needs some love from an artist
 
 namespace Modes_Dashboard {
 namespace {

src/inputs/website.h

@@ -1,6 +1,7 @@
 #pragma once
 #include <stdint.h>
 
+// currently unused, but it might be useful for pairing later
 // this class will make a hash without similar looking or sounding chars
 
 const char* safeChars = "23456789ABCDEFGHKLMNPQRSTUVWXYZ";
@@ -25,14 +26,12 @@ uint16_t reverse16(uint16_t in) {
 }
 
 // CRC POLYNOME = x15 + 1 =  1000 0000 0000 0001 = 0x8001
-uint16_t crc16(const uint8_t* array, uint8_t length, uint16_t polynome = 0x8001,
-               uint16_t startmask = 0x0000, uint16_t endmask = 0x0000, bool reverseIn = false,
-               bool reverseOut = false) {
+uint16_t crc16(const uint8_t* array, uint8_t length, uint16_t polynome = 0x8001, uint16_t startmask = 0x0000,
+               uint16_t endmask = 0x0000, bool reverseIn = false, bool reverseOut = false) {
     uint16_t crc = startmask;
     while (length--) {
         uint8_t data = *array++;
-        if (reverseIn)
-            data = reverse8(data);
+        if (reverseIn) data = reverse8(data);
         crc ^= ((uint16_t)data) << 8;
         for (uint8_t i = 8; i; i--) {
             if (crc & (1 << 15)) {
@@ -43,8 +42,7 @@ uint16_t crc16(const uint8_t* array, uint8_t length, uint16_t polynome = 0x8001,
             }
         }
     }
-    if (reverseOut)
-        crc = reverse16(crc);
+    if (reverseOut) crc = reverse16(crc);
     crc ^= endmask;
     return crc;
 }

src/modes/dashboard.h

@@ -10,8 +10,9 @@
 namespace WiFiLoginManager {
 
 namespace {
-// IPAddress testHost(8, 8, 8, 8);
-IPAddress testHost(1, 1, 1, 1);
+// IPAddress testHost(8, 8, 8, 8);  // google
+IPAddress testHost(1, 1, 1, 1); // cloudflare
+
 WiFiManager wifiManager;
 String _hostname;
 } // namespace