Skip to content

Commit 9538662

Browse files
committed
Slightly cleaner connection code
1 parent 09d7ae4 commit 9538662

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

mongoengine/connection.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -263,17 +263,17 @@ def _clean_settings(settings_dict):
263263
else:
264264
connection_class = MongoClient
265265

266-
# Re-use existing connection if one is suitable
266+
# Re-use existing connection if one is suitable.
267267
existing_connection = _find_existing_connection(raw_conn_settings)
268-
269-
# If an existing connection was found, assign it to the new alias
270268
if existing_connection:
271-
_connections[alias] = existing_connection
269+
connection = existing_connection
272270
else:
273-
_connections[alias] = _create_connection(alias=alias,
274-
connection_class=connection_class,
275-
**conn_settings)
276-
271+
connection = _create_connection(
272+
alias=alias,
273+
connection_class=connection_class,
274+
**conn_settings
275+
)
276+
_connections[alias] = connection
277277
return _connections[alias]
278278

279279

@@ -359,8 +359,11 @@ def connect(db=None, alias=DEFAULT_CONNECTION_NAME, **kwargs):
359359
new_conn_settings = _get_connection_settings(db, **kwargs)
360360

361361
if new_conn_settings != prev_conn_setting:
362-
raise MongoEngineConnectionError(
363-
'A different connection with alias `%s` was already registered. Use disconnect() first' % alias)
362+
err_msg = (
363+
u'A different connection with alias `{}` was already '
364+
u'registered. Use disconnect() first'
365+
).format(alias)
366+
raise MongoEngineConnectionError(err_msg)
364367
else:
365368
register_connection(alias, db, **kwargs)
366369

0 commit comments

Comments
 (0)