Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Use of private APIs leads to failing app review #18

Open
4 tasks done
asboy2035 opened this issue Feb 10, 2025 · 2 comments
Open
4 tasks done

🐞 Use of private APIs leads to failing app review #18

asboy2035 opened this issue Feb 10, 2025 · 2 comments

Comments

@asboy2035
Copy link

asboy2035 commented Feb 10, 2025

Bug Description

Hi,
Luminare uses ‘CGSetWindowBackgroundBlurRadius’ which is a private API, and this causes any apps that use it to fail Apple’s app review process. I suggest you don’t use private APIs, especially when there’s a public version available.

Thanks!

  • ash

Steps To Reproduce

  1. Implement Luminare in your app
  2. Try to go through App Review

Expected Behavior

App review succeeds or has other issues not from Luminare.

Actual Behavior

App review fails due to private API usage.

Screenshots

No response

macOS Version

Any, (I’m using 15.3)

Additional Context

No response

Final Checks

  • My issue is written in English
  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
  • I can help with fixing or developing this issue (tick if you can help).
@SenpaiHunters
Copy link
Collaborator

Check out #14 which is a rewrite, can't remember if it's also still using GSetWindowBackgroundBlurRadius if it isn't awesome, if it is, we'll look into it, there was and always is a reason we use a private API. So, as for right now, we're not much of a help, especially since that rewrite is in progress.

@asboy2035
Copy link
Author

I'll look into it, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants