-
Notifications
You must be signed in to change notification settings - Fork 145
Open
Labels
futureinvestigation neededFurther investigation is needed to determine the nature of the problem, or if it even is an issue.Further investigation is needed to determine the nature of the problem, or if it even is an issue.tbdtestingPRs/issues adding additional tests only, or primarily testing-focusedPRs/issues adding additional tests only, or primarily testing-focused
Description
Initial investigation arises from the infinite loop fix in #390, which it turns out was fixed separately by #413.
I tried throwing the following at Value::parseValue
:
/!;
//!;
///!;
////!;
The 1st and 3rd seemed fine, resulting in /
and ///
respectively. The 2nd and 4th resulted in UnexpectedTokenException: Identifier expected. Got “!;”
.
In terms of the metaphor "low-hanging-fruit", this isn't even fruit. I am just logging this so the information is captured, and that we can be mindful of the curious behaviour when revisiting that area of the code.
Metadata
Metadata
Assignees
Labels
futureinvestigation neededFurther investigation is needed to determine the nature of the problem, or if it even is an issue.Further investigation is needed to determine the nature of the problem, or if it even is an issue.tbdtestingPRs/issues adding additional tests only, or primarily testing-focusedPRs/issues adding additional tests only, or primarily testing-focused