Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications: Add a dropdown with options on the Feedback form #960

Open
bishwaspraveen opened this issue Aug 20, 2024 · 11 comments · May be fixed by #1210
Open

Notifications: Add a dropdown with options on the Feedback form #960

bishwaspraveen opened this issue Aug 20, 2024 · 11 comments · May be fixed by #1210
Assignees
@bishwaspraveen

Comments

@bishwaspraveen
Copy link
Contributor

bishwaspraveen commented Aug 20, 2024 •
edited
Loading

Description

On the feedback form, users are requested to provide their email address and choose from a selection of contact needs that include:

  • I need help or have a general question
  • I have a data/content question or comment
  • I would like to report an error
  • I have an idea or suggested improvement to share
  • General comment or feedback

Make sure to run this piece of code on shell to populate the dropdown options model after COSMOS deployment.

from feedback.models import FeedbackFormDropdown

# Create all default options
for option in FeedbackFormDropdown.DEFAULT_OPTIONS:
    FeedbackFormDropdown.objects.create(
        name=option['name'],
        display_order=option['display_order']
    )
@bishwaspraveen bishwaspraveen self-assigned this Aug 20, 2024
@bishwaspraveen
Copy link
Contributor Author

Image
Image

@bishwaspraveen
Copy link
Contributor Author

Image
Image

@bishwaspraveen
Copy link
Contributor Author

@nikitabalsara Can you take a look at the above backend changes that were made for the feedback form? It needs frontend implementation to add a dropdown for the feedback form with options as shown in this card's description. These changes haven't been deployed on COSMOS yet and will be once the frontend changes are ready.

@bishwaspraveen bishwaspraveen linked a pull request Sep 19, 2024 that will close this issue
Add a dropdown with options on the feedback form (backend changes) #1032
Closed
@nikitabalsara
Copy link

Hi @bishwaspraveen We will pick this up in the next PI. Just want to confirm if we have an API for the dropdown options? If we keep these options hard-coded on the frontend it will need an explicit deployment so it's better if we use an API which gives us the values.

@code-geek @shravan-lrm @kartiknagaraja-LRM @saurabh-LRM

@nikitabalsara
Copy link

Hi @bishwaspraveen Sharing a note once again on this - Just want to confirm if we have an API for the dropdown options. If we keep these options hard-coded on the front end it will need an explicit deployment so it's better if we use an API that gives us the values. We will add the category in the request body that shouldn't be a problem.

@kartiknagaraja-LRM @CarsonDavis

@CarsonDavis CarsonDavis changed the title Add a dropdown with options on the Feedback form Notifications: Add a dropdown with options on the Feedback form Jan 13, 2025
@bishwaspraveen
Copy link
Contributor Author

@nikitabalsara I'll be working on this in the next couple of days.

@bishwaspraveen bishwaspraveen removed a link to a pull request Jan 22, 2025
Add a dropdown with options on the feedback form (backend changes) #1032
Closed
@bishwaspraveen
Copy link
Contributor Author

bishwaspraveen commented Jan 29, 2025 •
edited
Loading

Image Image Image Image

@nikitabalsara Take a look at the above implementation and let mw know if this works or needs changes. I'll deploy it to COSMOS prod if this fits the needs.

@bishwaspraveen bishwaspraveen linked a pull request Jan 29, 2025 that will close this issue
960 notifications add a dropdown with options on the feedback form #1210
Open
@nikitabalsara
Copy link

nikitabalsara commented Jan 30, 2025 •
edited
Loading

Hi @bishwaspraveen Just one comment the dropdown option text will be the "subject" in the contact us API. We don't need the subject and dropdown_option both. The rest in terms of the dropdown options API seems to be fine. Thanks!

@nikitabalsara
Copy link

@bishwaspraveen On second thoughts I don't think any change is needed from your side we can handle that on the frontend too sending the dropdown text in the subject along with the dropdown option. Please let us know once it's deployed. However, we'll need to make sure the production form which doesn't have this change yet still continues to work as expected.

@nikitabalsara
Copy link

@ankit-lrm FYI

@nikitabalsara
Copy link

@bishwaspraveen Is this likely to be deployed during this sprint so that we can integrate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bishwaspraveen bishwaspraveen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

960 notifications add a dropdown with options on the feedback form NASA-IMPACT/COSMOS
2 participants
@bishwaspraveen @nikitabalsara