Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve title resolution; make it a background process #1006

Open
code-geek opened this issue Sep 6, 2024 · 2 comments · May be fixed by #1214
Open

Improve title resolution; make it a background process #1006

code-geek opened this issue Sep 6, 2024 · 2 comments · May be fixed by #1214
Assignees
@Kirandawadi

Comments

@code-geek
Copy link
Contributor

Description

Right now title resolution is a foreground process that is long-running and can possibly time out. We want to defer this to the background and have a mechanism to track when it succeeds/fails.

Implementation Considerations

  • Some way of storing success/failure status of title resolution in the database
  • If two title resolution tasks are kicked off at the same time, which one takes precedence, especially given they run in the background and we can't predict their order.

Deliverable

  • When a user adds a title pattern on the frontend, they are shown a message that their title pattern is being resolved
  • The user can then track this title pattern and see the status: "pending", "resolved", "failed"
  • If some title resolution fails, we need some logs
  • A logging model with an admin seems sufficient

Dependencies

No response
@CarsonDavis
Copy link
Collaborator

For now, it is probably fine to put title resolution errors within the DeltaResolvedTitleError model. In the future, we may want to integrate it with the broader notifications/logs system that has been proposed.

@Kirandawadi Kirandawadi linked a pull request Feb 3, 2025 that will close this issue
Improve title resolution make it a background process #1214
Open
@Kirandawadi
Copy link
Collaborator

Demo

  • Background resolution of titles
  • Can schedule resolution for multiple title patterns at once
Background_Title_Resolution.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kirandawadi Kirandawadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve title resolution make it a background process NASA-IMPACT/COSMOS
3 participants
@code-geek @CarsonDavis @Kirandawadi