Skip to content

fwd op fails transform - set qc? #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hkershaw-brown opened this issue Jan 30, 2025 · 3 comments
Open

fwd op fails transform - set qc? #819

hkershaw-brown opened this issue Jan 30, 2025 · 3 comments
Labels
QCEFF quantile conserving filters

Comments

@hkershaw-brown
Copy link
Member

hkershaw-brown commented Jan 30, 2025 •
edited
Loading

If the to_probit was not ok, do you want to set the qc to failed fwd op?

The other processes don't have access to obs_probit_trans_ok(owners_index) and so they will go ahead and calculate obs_increments because the qc is 0, then transform_to_probit which may or may not work?

Originally posted by @hkershaw-brown in #794 (comment)
@hkershaw-brown
Copy link
Member Author

related #681

@hkershaw-brown hkershaw-brown added the QCEFF quantile conserving filters label Jan 30, 2025
@hkershaw-brown hkershaw-brown mentioned this issue Jan 30, 2025
Merged
15 tasks
@hkershaw-brown
Copy link
Member Author

related to #833

@hkershaw-brown hkershaw-brown mentioned this issue Mar 5, 2025
Closed
@hkershaw-brown
Copy link
Member Author

I have been reproducing this with an external FO with one out-of-bounds value for lorenz_96_tracer:

obs_seq.out.2.FO.txt

Are fwd ops allowed to fail in this way?, if so need to catch them & give failing QC, e.g.
main...out-of-bounds-fwd-ops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QCEFF quantile conserving filters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkershaw-brown