Skip to content

bug: #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlaucar opened this issue Mar 20, 2025 · 1 comment
Closed

bug: #844

jlaucar opened this issue Mar 20, 2025 · 1 comment
Assignees

Comments

@jlaucar
Copy link
Contributor

jlaucar commented Mar 20, 2025

1.The upper limit on the loop in module bnrh_distribution_mod.f90, subroutine bnrh_cdf_initialized_vector appears to be incorrect. The index i should be looping over each entry in the array x to find the quantile corresponding to the ensemble member value. The upper bound on arrays x and quantiles is the intent(in) argument num, but the upper bound on the loop is p%ens_size. Current usage of this subroutine in DART always calls this subroutine with num being the same as the ensemble size, but it could be used for other applications. The upper bound on the loop counter should be changed to num.

Version of DART

This appears to be the case for all versions of DART that have used the bnrh_distribution_mod.f90.

@hkershaw-brown
Copy link
Member

fixed in #863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants